Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: ui/events/android/motion_event_android_unittest.cc

Issue 2054193002: Android mouse events shouldn't appear as TouchEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Kept old touch-like behavior in pre-M. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/android/motion_event_android_unittest.cc
diff --git a/ui/events/android/motion_event_android_unittest.cc b/ui/events/android/motion_event_android_unittest.cc
index 82ec1c5839886c4404407365a6dcc2a47cc56019..354c9159213ea10b008dbe92665aabfc543bd4d9 100644
--- a/ui/events/android/motion_event_android_unittest.cc
+++ b/ui/events/android/motion_event_android_unittest.cc
@@ -59,8 +59,8 @@ TEST(MotionEventAndroidTest, Constructor) {
kAndroidAltKeyDown,
raw_offset,
-raw_offset,
- p0,
- p1);
+ &p0,
+ &p1);
EXPECT_EQ(MotionEvent::ACTION_DOWN, event.GetAction());
EXPECT_EQ(event_time, event.GetEventTime());
@@ -107,8 +107,8 @@ TEST(MotionEventAndroidTest, Clone) {
0,
0,
0,
- p0,
- p1);
+ &p0,
+ &p1);
std::unique_ptr<MotionEvent> clone = event.Clone();
EXPECT_EQ(ui::test::ToString(event), ui::test::ToString(*clone));
@@ -132,8 +132,8 @@ TEST(MotionEventAndroidTest, Cancel) {
0,
0,
0,
- p0,
- p1);
+ &p0,
+ &p1);
std::unique_ptr<MotionEvent> cancel_event = event.Cancel();
EXPECT_EQ(MotionEvent::ACTION_CANCEL, cancel_event->GetAction());
@@ -165,8 +165,8 @@ TEST(MotionEventAndroidTest, InvalidOrientationsSanitized) {
0,
0,
0,
- p0,
- p1);
+ &p0,
+ &p1);
EXPECT_EQ(0.f, event.GetOrientation(0));
EXPECT_EQ(0.f, event.GetOrientation(1));
@@ -189,8 +189,8 @@ TEST(MotionEventAndroidTest, NonEmptyHistoryForNonMoveEventsSanitized) {
0,
0,
0,
- p0,
- p1);
+ &p0,
+ &p1);
EXPECT_EQ(0U, event.GetHistorySize());
}
@@ -215,8 +215,8 @@ TEST(MotionEventAndroidTest, ActionIndexForPointerDown) {
0,
0,
0,
- p0,
- p1);
+ &p0,
+ &p1);
EXPECT_EQ(MotionEvent::ACTION_POINTER_DOWN, event.GetAction());
EXPECT_EQ(action_index, event.GetActionIndex());

Powered by Google App Engine
This is Rietveld 408576698