Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(922)

Unified Diff: content/browser/android/content_view_core_impl.h

Issue 2054193002: Android mouse events shouldn't appear as TouchEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added working mouse buttons. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/content_view_core_impl.h
diff --git a/content/browser/android/content_view_core_impl.h b/content/browser/android/content_view_core_impl.h
index d424789e1e996ffea1541dfae1847f0acafc2361..d3a2f9f7033e19fb0dc90774152ec85f7a3d770c 100644
--- a/content/browser/android/content_view_core_impl.h
+++ b/content/browser/android/content_view_core_impl.h
@@ -128,12 +128,18 @@ class ContentViewCoreImpl : public ContentViewCore,
jint android_button_state,
jint android_meta_state,
jboolean is_touch_handle_event);
- jboolean SendMouseMoveEvent(JNIEnv* env,
- const base::android::JavaParamRef<jobject>& obj,
- jlong time_ms,
- jfloat x,
- jfloat y,
- jint tool_type);
+ jboolean SendMouseEvent(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ jlong time_ms,
+ jint android_action,
+ jfloat x,
+ jfloat y,
+ jint pointer_id,
+ jfloat pressure,
+ jfloat orientation,
+ jfloat tilt,
+ jint android_button_state,
+ jint tool_type);
jboolean SendMouseWheelEvent(JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
jlong time_ms,
@@ -472,6 +478,9 @@ class ContentViewCoreImpl : public ContentViewCore,
bool accessibility_enabled_;
+ // The buttons currently depressed, see MotionEvent.getButtonState().
+ int button_state_;
+
// Manages injecting Java objects.
scoped_refptr<GinJavaBridgeDispatcherHost> java_bridge_dispatcher_host_;
« no previous file with comments | « no previous file | content/browser/android/content_view_core_impl.cc » ('j') | content/browser/android/content_view_core_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698