Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2191)

Unified Diff: content/public/test/text_input_test_utils.h

Issue 2054163003: Fix SitePerProcessTextInputManagerTest.StopTrackingCrashedChildFrame on CFI Bots. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Do not assume we only have 2 views registered in the begining. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/text_input_test_utils.h
diff --git a/content/public/test/text_input_test_utils.h b/content/public/test/text_input_test_utils.h
index 5b78a5602e4b4c3669e318e37eb0d71a938c8a15..5c9c1ddf067d0ff93473c4bcf36cfc2778cd8d27 100644
--- a/content/public/test/text_input_test_utils.h
+++ b/content/public/test/text_input_test_utils.h
@@ -7,6 +7,7 @@
#include <string>
#include <unordered_map>
+#include <unordered_set>
#include <vector>
#include "base/callback.h"
@@ -32,6 +33,12 @@ bool GetTextInputTypeForView(WebContents* web_contents,
RenderWidgetHostView* view,
ui::TextInputType* type);
+// This method returns the set of all the views which are currently being
Charlie Reis 2016/06/13 18:46:13 nit: all views nit: currently registered Also, le
EhsanK 2016/06/25 00:10:35 This method is changed to return the count only no
+// registered with the TextInputManager, as in, their TextInputState is being
+// tracked by it.
+std::unordered_set<RenderWidgetHostView*>
+GetAllViewsRegisteredWithTextInputManager(WebContents* web_contents);
+
// Returns the RWHV corresponding to the frame with a focused <input> within the
// given WebContents.
RenderWidgetHostView* GetActiveViewFromWebContents(WebContents* web_contents);

Powered by Google App Engine
This is Rietveld 408576698