content/browser/frame_host/render_widget_host_view_child_frame.cc - Issue 2054163003: Fix SitePerProcessTextInputManagerTest.StopTrackingCrashedChildFrame on CFI Bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.cc

Issue 2054163003: Fix SitePerProcessTextInputManagerTest.StopTrackingCrashedChildFrame on CFI Bots. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed the added code to RenderWidgetHostViewChildFrame::Destroy(). Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/site_per_process_text_input_browsertest.cc ('k') | content/browser/renderer_host/text_input_manager.h » ('j') | content/public/test/text_input_test_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_widget_host_view_child_frame.cc

diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc

index 88ea407cb7071d6c6b3539d591e0caf8d6f47146..99b3c41424d58cd3ccea1d87d1fdcb1d5d311a19 100644

--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc

+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc

@@ -28,6 +28,7 @@

#include "content/browser/renderer_host/render_widget_host_delegate.h"

#include "content/browser/renderer_host/render_widget_host_impl.h"

#include "content/browser/renderer_host/render_widget_host_input_event_router.h"

+#include "content/browser/renderer_host/text_input_manager.h"

Charlie Reis 2016/06/28 21:39:34 nit: No longer needed.

EhsanK 2016/06/28 22:47:10 Acknowledged.

#include "content/common/text_input_state.h"

#include "content/common/view_messages.h"

#include "content/public/browser/render_process_host.h"

@@ -287,6 +288,7 @@ void RenderWidgetHostViewChildFrame::Destroy() {

host_->SetView(nullptr);

host_ = nullptr;

Charlie Reis 2016/06/28 21:39:34 nit: No longer needed. (This file shouldn't need

EhsanK 2016/06/28 22:47:10 Acknowledged.

base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this);

}