Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2054133002: [--runtime-call-stats] Fix ACCESSOR handler computation (Closed)

Created:
4 years, 6 months ago by Jakob Kummerow
Modified:
4 years, 6 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[--runtime-call-stats] Fix ACCESSOR handler computation When running with FLAG_runtime_call_stats, native accessor accesses must go through the runtime for accurate accounting. Previously the slow_stub() was used as a handler in order to accomplish this, but it could never be looked up from the code cache successfully due to mismatched code flags, which could cause more handler recompilations than in normal operation. This patch fixes that by emitting a runtime call into the compiled handler instead of using the slow_stub(). Drive-by cleanup: drop the unused StoreIC_Megamorphic builtin. Committed: https://crrev.com/31ca317af3c7c140143da616701ad45b7a08906e Cr-Commit-Position: refs/heads/master@{#36926}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -171 lines) Patch
M src/builtins.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/builtins.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M src/counters.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 3 chunks +19 lines, -6 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ic/ic.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/ic/ic.cc View 1 6 chunks +6 lines, -9 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/ic/mips64/ic-mips64.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/ic/ppc/ic-ppc.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M src/ic/s390/ic-s390.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/ic/x87/ic-x87.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Jakob Kummerow
PTAL.
4 years, 6 months ago (2016-06-13 10:55:11 UTC) #2
Camillo Bruni
LGTM for ultimate manual register allocation fun!
4 years, 6 months ago (2016-06-13 11:34:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054133002/1
4 years, 6 months ago (2016-06-13 11:36:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/3109) v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED, ...
4 years, 6 months ago (2016-06-13 11:37:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054133002/20001
4 years, 6 months ago (2016-06-13 11:42:10 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-13 12:11:58 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 12:14:28 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/31ca317af3c7c140143da616701ad45b7a08906e
Cr-Commit-Position: refs/heads/master@{#36926}

Powered by Google App Engine
This is Rietveld 408576698