Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Issue 205403004: [DevTools] Allow overriding only the device scale factor. (Closed)

Created:
6 years, 9 months ago by dgozman
Modified:
6 years, 9 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[DevTools] Allow overriding only the device scale factor. BUG=327641 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170061

Patch Set 1 #

Patch Set 2 : Rebase, one test fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -13 lines) Patch
M LayoutTests/inspector/device-emulation/device-emulation-320-2x-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/inspector/device-emulation/device-emulation-320-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/inspector/device-emulation/device-emulation-980-2x-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/inspector/device-emulation/device-emulation-980-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/inspector/device-emulation/device-emulation-dw-2x-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/inspector/device-emulation/device-emulation-dw-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/inspector/device-emulation/device-emulation-none-2x-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/inspector/device-emulation/device-emulation-none-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/inspector/device-emulation/device-emulation-restore-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/inspector/device-emulation/device-emulation-scale-only.html View 1 chunk +86 lines, -0 lines 0 comments Download
A LayoutTests/inspector/device-emulation/device-emulation-scale-only-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M LayoutTests/inspector/device-emulation/device-emulation-small-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/inspector/device-emulation/device-emulation-test.js View 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/inspector/text-autosizing-override.html View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 5 chunks +14 lines, -8 lines 0 comments Download
M Source/devtools/front_end/OverridesSupport.js View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
dgozman
Take a look please. Based on https://codereview.chromium.org/207553003/.
6 years, 9 months ago (2014-03-25 13:23:09 UTC) #1
pfeldman
lgtm
6 years, 9 months ago (2014-03-25 16:26:49 UTC) #2
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 9 months ago (2014-03-26 12:39:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/205403004/1
6 years, 9 months ago (2014-03-26 12:39:10 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 13:08:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-26 13:08:31 UTC) #6
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 9 months ago (2014-03-26 13:23:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/205403004/90001
6 years, 9 months ago (2014-03-26 13:23:17 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 14:31:47 UTC) #9
Message was sent while issue was closed.
Change committed as 170061

Powered by Google App Engine
This is Rietveld 408576698