Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2054023002: [CSS Paint API] Add StylePropertyMap as an argument to the paint function. (Closed)

Created:
4 years, 6 months ago by ikilpatrick
Modified:
4 years, 6 months ago
CC:
chromium-reviews, blink-reviews-css, haraken, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CSS Paint API] Add StylePropertyMap as an argument to the paint function. This adds the FilteredComputedStylePropertyMap as an argument to the CSS paint API function with only the listed inputProperties. BUG=578252 Committed: https://crrev.com/9dd1fcf2ba902f87e64379a1d2e5a4d6562502dc Cr-Commit-Position: refs/heads/master@{#400115}

Patch Set 1 #

Patch Set 2 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -9 lines) Patch
A third_party/WebKit/LayoutTests/csspaint/resources/generate-paint-style-logging.js View 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/csspaint/style-background-image.html View 1 chunk +39 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/csspaint/style-background-image-expected.txt View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/csspaint/style-before-pseudo.html View 1 chunk +42 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/csspaint/style-before-pseudo-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/csspaint/style-first-letter-pseudo.html View 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/csspaint/style-first-letter-pseudo-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPaintImageGenerator.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSPaintValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp View 4 chunks +12 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/csspaint/CSSPaintImageGeneratorImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
ikilpatrick
4 years, 6 months ago (2016-06-10 04:34:44 UTC) #2
meade_UTC10
This seems fine to me, but I have to say I don't fully understand what's ...
4 years, 6 months ago (2016-06-14 09:51:46 UTC) #3
Timothy Loh
lgtm
4 years, 6 months ago (2016-06-15 13:34:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2054023002/20001
4 years, 6 months ago (2016-06-16 08:39:36 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-16 09:05:43 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 09:05:50 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 09:07:29 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9dd1fcf2ba902f87e64379a1d2e5a4d6562502dc
Cr-Commit-Position: refs/heads/master@{#400115}

Powered by Google App Engine
This is Rietveld 408576698