Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Unified Diff: chrome/browser/resources/settings/settings_page_css.html

Issue 2054013002: [MD settings] advanced toggle; add scrollWhenReady (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_page_css.html
diff --git a/chrome/browser/resources/settings/settings_page_css.html b/chrome/browser/resources/settings/settings_page_css.html
index 541d6be840a804d61d5361212b0593759d297ac0..ccd59f501fdb940cc1e413773f85d25b1e822019 100644
--- a/chrome/browser/resources/settings/settings_page_css.html
+++ b/chrome/browser/resources/settings/settings_page_css.html
@@ -4,7 +4,6 @@
<template>
<style include="main-page-styles">
:host {
- --settings-page-padding-top: 21px;
box-sizing: border-box;
display: block;
height: inherit;
@@ -25,22 +24,6 @@
* with the top item in the side nav menu. Both things are desired
* by Alan (bettes@). */
margin-bottom: 3px;
- /* TODO(michaelpg): This makes more sense as padding, but uses margin as
- * a workaround for crbug.com/617287. Because margins collapse, add 3px
- * to retain mostly the same spacing. */
- margin-top: calc(var(--settings-page-padding-top) + 3px);
- }
-
- :host > div > :first-of-type {
- /* TODO(michaelpg): This is offset because of the previous addition of
- * 3px: crbug.com/617287. */
- margin-top: var(--settings-page-padding-top);
- }
-
- .expanded.frozen {
- /* TODO(michaelpg): This is zeroed out because of the previous
- * replacement of margin with padding, above: crbug.com/617287. */
- margin-top: 0; /* -var(--settings-page-padding-top); */
}
</style>
</template>

Powered by Google App Engine
This is Rietveld 408576698