Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.js

Issue 2054013002: [MD settings] advanced toggle; add scrollWhenReady (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_main/settings_main.js
diff --git a/chrome/browser/resources/settings/settings_main/settings_main.js b/chrome/browser/resources/settings/settings_main/settings_main.js
index b8a061845bc8925ee9705f08eeb277b6da89e888..11cd9dd684eebba61b2ff7ec7ffed466e63f3575 100644
--- a/chrome/browser/resources/settings/settings_main/settings_main.js
+++ b/chrome/browser/resources/settings/settings_main/settings_main.js
@@ -63,10 +63,28 @@ Polymer({
document.addEventListener('toggle-advanced-page', function(e) {
this.showAdvancedPage_ = e.detail;
this.isAdvancedMenuOpen_ = e.detail;
+ if (this.showAdvancedPage_) {
+ scrollWhenReady(
+ function() {
+ return this.$$('settings-advanced-page');
+ }.bind(this),
+ function() {
+ return this.$$('#toggleContainer');
+ }.bind(this));
+ }
}.bind(this));
},
/**
+ * @param {boolean} opened Whether the menu is expanded.
+ * @return {string} Which icon to use.
+ * @private
+ * */
+ arrowState_: function(opened) {
+ return opened ? 'settings:arrow-drop-up' : 'cr:arrow-drop-down';
+ },
+
+ /**
* @param {!SettingsRoute} newRoute
* @private
*/
@@ -83,7 +101,7 @@ Polymer({
(this.isAdvancedMenuOpen_ && this.showAdvancedToggle_) ||
newRoute.page == 'advanced';
- this.$.pageContainer.style.height = isSubpage ? '100%' : '';
+ this.style.height = isSubpage ? '100%' : '';
},
/** @private */

Powered by Google App Engine
This is Rietveld 408576698