chrome/browser/resources/settings/basic_page/basic_page.js - Issue 2054013002: [MD settings] advanced toggle; add scrollWhenReady

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/basic_page/basic_page.js

Issue 2054013002: [MD settings] advanced toggle; add scrollWhenReady (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/basic_page/basic_page.js

diff --git a/chrome/browser/resources/settings/basic_page/basic_page.js b/chrome/browser/resources/settings/basic_page/basic_page.js

index b6141d01de72fe3efd83a862079db9bf00a6f7a2..311740da64b8a5c663aa97501bab4f7468958c24 100644

--- a/chrome/browser/resources/settings/basic_page/basic_page.js

+++ b/chrome/browser/resources/settings/basic_page/basic_page.js

@@ -49,12 +49,6 @@ Polymer({

sectionSelector: 'settings-section',

- /** @override */

- attached: function() {

- /** @override */

- this.scroller = this.parentElement;

- },

onResetDone_: function() {

this.showResetProfileBanner_ = false;