Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Side by Side Diff: chrome/browser/resources/settings/about_page/about_page.js

Issue 2054013002: [MD settings] advanced toggle; add scrollWhenReady (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/advanced_page/advanced_page.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 'settings-about-page' contains version and OS related 6 * @fileoverview 'settings-about-page' contains version and OS related
7 * information. 7 * information.
8 */ 8 */
9 Polymer({ 9 Polymer({
10 is: 'settings-about-page', 10 is: 'settings-about-page',
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 this.startListening_(); 85 this.startListening_();
86 }.bind(this)); 86 }.bind(this));
87 87
88 this.aboutBrowserProxy_.getRegulatoryInfo().then(function(info) { 88 this.aboutBrowserProxy_.getRegulatoryInfo().then(function(info) {
89 this.regulatoryInfo_ = info; 89 this.regulatoryInfo_ = info;
90 }.bind(this)); 90 }.bind(this));
91 </if> 91 </if>
92 <if expr="not chromeos"> 92 <if expr="not chromeos">
93 this.startListening_(); 93 this.startListening_();
94 </if> 94 </if>
95
96 this.scroller = this.parentElement;
97 }, 95 },
98 96
99 /** @private */ 97 /** @private */
100 startListening_: function() { 98 startListening_: function() {
101 this.addWebUIListener( 99 this.addWebUIListener(
102 'update-status-changed', 100 'update-status-changed',
103 this.onUpdateStatusChanged_.bind(this)); 101 this.onUpdateStatusChanged_.bind(this));
104 this.aboutBrowserProxy_.refreshUpdateStatus(); 102 this.aboutBrowserProxy_.refreshUpdateStatus();
105 }, 103 },
106 104
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
295 }, 293 },
296 </if> 294 </if>
297 295
298 <if expr="_google_chrome"> 296 <if expr="_google_chrome">
299 /** @private */ 297 /** @private */
300 onReportIssueTap_: function() { 298 onReportIssueTap_: function() {
301 this.aboutBrowserProxy_.openFeedbackDialog(); 299 this.aboutBrowserProxy_.openFeedbackDialog();
302 }, 300 },
303 </if> 301 </if>
304 }); 302 });
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/advanced_page/advanced_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698