Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2053983003: cc : Move LayerImpl::parent to test properties (Closed)

Created:
4 years, 6 months ago by jaydasika
Modified:
4 years, 6 months ago
Reviewers:
sunxd, ajuma, weiliangc
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc : Move LayerImpl::parent to test properties BUG=602438 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/f419bf7a73a54108381698ad19e951e80ae94c87 Cr-Commit-Position: refs/heads/master@{#399875}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -76 lines) Patch
M cc/layers/layer_impl.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M cc/layers/layer_impl.cc View 1 3 chunks +2 lines, -7 lines 0 comments Download
M cc/layers/layer_impl_test_properties.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/layer_impl_test_properties.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M cc/layers/layer_list_iterator.cc View 3 chunks +13 lines, -6 lines 0 comments Download
M cc/trees/damage_tracker_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 6 chunks +9 lines, -9 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 14 chunks +48 lines, -24 lines 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/property_tree_builder.cc View 1 13 chunks +28 lines, -21 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
jaydasika
4 years, 6 months ago (2016-06-10 20:08:44 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053983003/1
4 years, 6 months ago (2016-06-10 20:09:27 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-10 21:35:22 UTC) #8
ajuma
lgtm https://codereview.chromium.org/2053983003/diff/1/cc/trees/layer_tree_host_impl_unittest.cc File cc/trees/layer_tree_host_impl_unittest.cc (right): https://codereview.chromium.org/2053983003/diff/1/cc/trees/layer_tree_host_impl_unittest.cc#newcode2028 cc/trees/layer_tree_host_impl_unittest.cc:2028: // scroll_test_properties()->parent don't This should still say 'scroll_parent'
4 years, 6 months ago (2016-06-10 22:32:59 UTC) #9
jaydasika
https://codereview.chromium.org/2053983003/diff/1/cc/trees/layer_tree_host_impl_unittest.cc File cc/trees/layer_tree_host_impl_unittest.cc (right): https://codereview.chromium.org/2053983003/diff/1/cc/trees/layer_tree_host_impl_unittest.cc#newcode2028 cc/trees/layer_tree_host_impl_unittest.cc:2028: // scroll_test_properties()->parent don't On 2016/06/10 22:32:58, ajuma wrote: > ...
4 years, 6 months ago (2016-06-15 09:18:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053983003/60001
4 years, 6 months ago (2016-06-15 09:19:00 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 6 months ago (2016-06-15 10:21:37 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 10:25:17 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f419bf7a73a54108381698ad19e951e80ae94c87
Cr-Commit-Position: refs/heads/master@{#399875}

Powered by Google App Engine
This is Rietveld 408576698