Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2053983002: WebGL: Three small fixes to Image CHROMIUM logic. (Closed)

Created:
4 years, 6 months ago by erikchen
Modified:
4 years, 6 months ago
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, haraken, Rik, f(malita), blink-reviews, piman+watch_chromium.org, Stephen Chennney, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebGL: Three small fixes to Image CHROMIUM logic. 1. Use the newly added method DescheduleUntilFinishedCHROMIUM() to add back pressure. 2. Update the color mask appropriately before calling clearFramebuffers(). 3. Plumb gpuMemoryBufferId through to the mailbox. BUG=611805, 617249, 607130 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/7843491fb012d3d3a37f77355b92d999da732bca Cr-Commit-Position: refs/heads/master@{#399231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
erikchen
kbr: Please review.
4 years, 6 months ago (2016-06-09 23:59:36 UTC) #3
erikchen
On 2016/06/09 23:59:36, erikchen wrote: > kbr: Please review. This CL is tested by: https://github.com/KhronosGroup/WebGL/pull/1763
4 years, 6 months ago (2016-06-10 01:07:22 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053983002/1
4 years, 6 months ago (2016-06-10 01:07:37 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ...
4 years, 6 months ago (2016-06-10 03:09:04 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053983002/1
4 years, 6 months ago (2016-06-10 15:32:35 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-10 16:36:37 UTC) #12
Ken Russell (switch to Gerrit)
Great! LGTM.
4 years, 6 months ago (2016-06-10 17:48:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053983002/1
4 years, 6 months ago (2016-06-10 18:12:56 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 18:18:00 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 18:19:35 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7843491fb012d3d3a37f77355b92d999da732bca
Cr-Commit-Position: refs/heads/master@{#399231}

Powered by Google App Engine
This is Rietveld 408576698