Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2053963002: Avoid casts via correct types in fgas_textbreak (Closed)

Created:
4 years, 6 months ago by Tom Sepez
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Avoid casts via correct types in fgas_textbreak FLW_DATEINFO cast not required. Committed: https://pdfium.googlesource.com/pdfium/+/215507d8d612d4269723b49aaf28468b634f68ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -57 lines) Patch
M xfa/fgas/layout/fgas_textbreak.h View 1 chunk +6 lines, -6 lines 0 comments Download
M xfa/fgas/layout/fgas_textbreak.cpp View 12 chunks +37 lines, -33 lines 0 comments Download
M xfa/fwl/basewidget/fwl_monthcalendarimp.cpp View 11 chunks +16 lines, -17 lines 0 comments Download
M xfa/fxfa/app/xfa_rendercontext.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Tom Sepez
Lei, pls. review.
4 years, 6 months ago (2016-06-09 23:08:52 UTC) #2
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-09 23:16:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053963002/1
4 years, 6 months ago (2016-06-09 23:17:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac on master.tryserver.client.pdfium (JOB_TIMED_OUT, no build URL) mac_no_v8 on ...
4 years, 6 months ago (2016-06-10 01:07:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053963002/1
4 years, 6 months ago (2016-06-10 02:05:34 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 02:05:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/215507d8d612d4269723b49aaf28468b634f...

Powered by Google App Engine
This is Rietveld 408576698