base/strings/string_number_conversions.cc - Issue 2053953002: Add chrome_crash_reporter_client_win.cc to the source file list for chrome_elf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/strings/string_number_conversions.cc

Issue 2053953002: Add chrome_crash_reporter_client_win.cc to the source file list for chrome_elf (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/strings/string_number_conversions.cc

diff --git a/base/strings/string_number_conversions.cc b/base/strings/string_number_conversions.cc

index f4cf6ec521f1cd0d1c663df54bc792a67a76bc3c..755811ded7e32beea4221ca128fee3dc0fb2d8a9 100644

--- a/base/strings/string_number_conversions.cc

+++ b/base/strings/string_number_conversions.cc

@@ -12,10 +12,8 @@

#include <limits>

#include "base/logging.h"

-#include "base/numerics/safe_conversions.h"

#include "base/numerics/safe_math.h"

#include "base/scoped_clear_errno.h"

-#include "base/strings/utf_string_conversions.h"

#include "base/third_party/dmg_fp/dmg_fp.h"

namespace base {

« no previous file with comments | « base/process/launch_win.cc ('k') | base/strings/string_util.cc » ('j') | no next file with comments »