Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2693)

Unified Diff: base/trace_event/winheap_dump_provider_win.cc

Issue 2053953002: Add chrome_crash_reporter_client_win.cc to the source file list for chrome_elf (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/winheap_dump_provider_win.cc
diff --git a/base/trace_event/winheap_dump_provider_win.cc b/base/trace_event/winheap_dump_provider_win.cc
index 80956369cca218a4247a1e36fe873ca9da963670..250ae6fbfb315b7c7aed31b62317129de5cdcf53 100644
--- a/base/trace_event/winheap_dump_provider_win.cc
+++ b/base/trace_event/winheap_dump_provider_win.cc
@@ -9,7 +9,6 @@
#include "base/debug/profiler.h"
#include "base/strings/string_util.h"
#include "base/trace_event/process_memory_dump.h"
-#include "base/win/windows_version.h"
namespace base {
namespace trace_event {
@@ -60,9 +59,6 @@ bool WinHeapDumpProvider::OnMemoryDump(const MemoryDumpArgs& args,
// known for creating heaps with this particular flag. For this reason
// this function should be disabled on XP.
//
- // See https://crbug.com/487291 for more details about this.
- if (base::win::GetVersion() < base::win::VERSION_VISTA)
- return false;
// Disable this dump provider for the SyzyASan instrumented build
// because they don't support the heap walking functions yet.

Powered by Google App Engine
This is Rietveld 408576698