Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: base/strings/string_number_conversions.cc

Issue 2053953002: Add chrome_crash_reporter_client_win.cc to the source file list for chrome_elf (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add dbghelp.dll to the list of delay loads Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/strings/string_number_conversions.cc
diff --git a/base/strings/string_number_conversions.cc b/base/strings/string_number_conversions.cc
index f4cf6ec521f1cd0d1c663df54bc792a67a76bc3c..79fd8c4dbada9555a865dd96b90967a853d26d55 100644
--- a/base/strings/string_number_conversions.cc
+++ b/base/strings/string_number_conversions.cc
@@ -12,10 +12,8 @@
#include <limits>
#include "base/logging.h"
-#include "base/numerics/safe_conversions.h"
#include "base/numerics/safe_math.h"
#include "base/scoped_clear_errno.h"
-#include "base/strings/utf_string_conversions.h"
#include "base/third_party/dmg_fp/dmg_fp.h"
namespace base {
@@ -138,7 +136,6 @@ class IteratorRangeToNumber {
const_iterator end,
value_type* output) {
bool valid = true;
-
while (begin != end && LocalIsWhitespace(*begin)) {
valid = false;
++begin;
@@ -159,7 +156,6 @@ class IteratorRangeToNumber {
valid = false;
}
}
-
return valid;
}

Powered by Google App Engine
This is Rietveld 408576698