chrome_elf/BUILD.gn - Issue 2053953002: Add chrome_crash_reporter_client_win.cc to the source file list for chrome_elf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_elf/BUILD.gn

Issue 2053953002: Add chrome_crash_reporter_client_win.cc to the source file list for chrome_elf (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix kasko annotations Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome_elf/BUILD.gn

diff --git a/chrome_elf/BUILD.gn b/chrome_elf/BUILD.gn

index 9e97c5a3c193b2ebbc37f3998fe068aacec63318..b84ab4d251955962dd74f873c36cbc3cefdf34d8 100644

--- a/chrome_elf/BUILD.gn

+++ b/chrome_elf/BUILD.gn

@@ -22,8 +22,13 @@ windows_manifest("chrome_elf_manifest") {

type = "dll"

}

+# We should move chrome_result_codes.h to another target which does not bring

+# in the world.

shared_library("chrome_elf") {

sources = [

+ "//chrome/app/chrome_crash_reporter_client_win.cc",

+ "//chrome/app/chrome_crash_reporter_client_win.h",

+ "//chrome/common/chrome_result_codes.h",

"chrome_elf.def",

"chrome_elf_main.cc",

"chrome_elf_main.h",

@@ -34,8 +39,12 @@ shared_library("chrome_elf") {

":chrome_elf_manifest",

":chrome_elf_resources",

":common",

+ "//base",

"//build/config/sanitizers:deps",

"//chrome/install_static:install_static_util",

+ "//components/crash/content/app",

+ "//components/crash/core/common",

+ "//content/public/common:result_codes",

]

configs += [ "//build/config/win:windowed" ]

configs -= [ "//build/config/win:console" ]

« chrome/app/chrome_crash_reporter_client_win.cc ('K') | « chrome/install_static/install_util.cc ('k') | chrome_elf/DEPS » ('j') | chrome_elf/chrome_elf.gyp » ('J')