base/threading/platform_thread_win.cc - Issue 2053953002: Add chrome_crash_reporter_client_win.cc to the source file list for chrome_elf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/threading/platform_thread_win.cc

Issue 2053953002: Add chrome_crash_reporter_client_win.cc to the source file list for chrome_elf (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix kasko annotations Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/threading/platform_thread_win.cc

diff --git a/base/threading/platform_thread_win.cc b/base/threading/platform_thread_win.cc

index eae236634d1d9f98618d53508af11208ad0b6781..50c4d1e0ef3b1fe6ada2e45a374d1fa0c23862fe 100644

--- a/base/threading/platform_thread_win.cc

+++ b/base/threading/platform_thread_win.cc

@@ -13,7 +13,6 @@

#include "base/threading/thread_restrictions.h"

#include "base/tracked_objects.h"

#include "base/win/scoped_handle.h"

-#include "base/win/windows_version.h"

namespace base {

@@ -100,7 +99,7 @@ bool CreateThreadInternal(size_t stack_size,

PlatformThreadHandle* out_thread_handle,

ThreadPriority priority) {

unsigned int flags = 0;

- if (stack_size > 0 && base::win::GetVersion() >= base::win::VERSION_XP) {

grt (UTC plus 2) 2016/06/10 14:20:00 yay!

ananta 2016/06/10 18:29:57 Yeah. Harmless line of code which pulled in user32

+ if (stack_size > 0) {

flags = STACK_SIZE_PARAM_IS_A_RESERVATION;

} else {

stack_size = 0;

« base/logging.cc ('K') | « base/logging.cc ('k') | chrome/app/chrome_crash_reporter_client_win.h » ('j') | chrome/app/chrome_crash_reporter_client_win.cc » ('J')