Add chrome_crash_reporter_client_win.cc to the source file list for chrome_elf

base/trace_event/winheap_dump_provider_win.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/trace_event/winheap_dump_provider_win.h"
 
 #include <windows.h>
 
 #include "base/debug/profiler.h"
 #include "base/strings/string_util.h"
 #include "base/trace_event/process_memory_dump.h"
-#include "base/win/windows_version.h"
 
 namespace base {
 namespace trace_event {
 
 #define DUMP_ROOT_NAME "winheap"
 // static
 const char WinHeapDumpProvider::kAllocatedObjects[] =
     DUMP_ROOT_NAME "/allocated_objects";
 
 namespace {
@@ skipping 26 matching lines @@
 
 bool WinHeapDumpProvider::OnMemoryDump(const MemoryDumpArgs& args,
                                        ProcessMemoryDump* pmd) {
   // This method might be flaky for 2 reasons:
   //   - GetProcessHeaps is racy by design. It returns a snapshot of the
   //     available heaps, but there's no guarantee that that snapshot remains
   //     valid. If a heap disappears between GetProcessHeaps() and HeapWalk()
   //     then chaos should be assumed. This flakyness is acceptable for tracing.
   //   - The MSDN page for HeapLock says: "If the HeapLock function is called on
   //     a heap created with the HEAP_NO_SERIALIZATION flag, the results are
   //     undefined.". This is a problem on Windows XP where some system DLLs are

[Lei Zhang, 2016/06/15 22:50:45]

Since we are removing pre-Win7 bits, can this go away too?

[ananta, 2016/06/15 23:09:53]

Thanks. Done

   //     known for creating heaps with this particular flag. For this reason
   //     this function should be disabled on XP.
   //
-  // See https://crbug.com/487291 for more details about this.
-  if (base::win::GetVersion() < base::win::VERSION_VISTA)
-    return false;
 
   // Disable this dump provider for the SyzyASan instrumented build
   // because they don't support the heap walking functions yet.
 #if defined(SYZYASAN)
   if (base::debug::IsBinaryInstrumented())
     return false;
 #endif
 
   // Retrieves the number of heaps in the current process.
   DWORD number_of_heaps = ::GetProcessHeaps(0, NULL);
@@ skipping 44 matching lines @@
     } else if ((heap_entry.wFlags & PROCESS_HEAP_REGION) != 0) {
       heap_info->committed_size += heap_entry.Region.dwCommittedSize;
     }
   }
   CHECK(::HeapUnlock(heap_info->heap_id) == TRUE);
   return true;
 }
 
 }  // namespace trace_event
 }  // namespace base