Add chrome_crash_reporter_client_win.cc to the source file list for chrome_elf

chrome/install_static/install_util_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/install_static/install_util.h"
 
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using ::testing::ElementsAre;
@@ skipping 112 matching lines @@
 
   // Case 10. Version1 > Version2. Multiple digit numbers.
   EXPECT_TRUE(CompareVersionStrings("0.0.12.1", "0.0.10.3", &result));
   EXPECT_EQ(1, result);
 
   // Case 11. Version1 < Version2. Multiple digit number.
   EXPECT_TRUE(CompareVersionStrings("10.11.12.13", "12.11.12.13", &result));
   EXPECT_EQ(-1, result);
 }
 
+// Tests the install_static::GetSwitchValueFromCommandLine function.
+TEST(InstallStaticTest, GetSwitchValueFromCommandLineTest) {
+  // Simple case with one switch.
+  std::string value =
+      GetSwitchValueFromCommandLine("c:\\temp\bleh.exe --type=bar", "type");

[grt (UTC plus 2), 2016/06/15 15:49:21]

\b -> \\b here and below

[ananta, 2016/06/15 22:10:28]

Done.

+  EXPECT_EQ(value, "bar");
+
+  // Multiple switches with trailing spaces between them.
+  value = GetSwitchValueFromCommandLine(
+      "c:\\temp\bleh.exe --type=bar  --abc=def bleh", "abc");
+  EXPECT_EQ(value, "def");
+
+  // Multiple switches with trailing spaces and tabs between them.
+  value = GetSwitchValueFromCommandLine(
+      "c:\\temp\bleh.exe --type=bar \t\t\t --abc=def bleh", "abc");
+  EXPECT_EQ(value, "def");
+
+  // Non existent switch.
+  value = GetSwitchValueFromCommandLine(
+      "c:\\temp\bleh.exe --foo=bar  --abc=def bleh", "type");
+  EXPECT_EQ(value, "");
+
+  // Non existent switch.
+  value = GetSwitchValueFromCommandLine("c:\\temp\bleh.exe", "type");
+  EXPECT_EQ(value, "");
+
+  // Non existent switch.
+  value = GetSwitchValueFromCommandLine("c:\\temp\bleh.exe type=bar", "type");
+  EXPECT_EQ(value, "");
+
+  // Trailing spaces after the switch.
+  value = GetSwitchValueFromCommandLine(
+      "c:\\temp\bleh.exe --type=bar      \t\t", "type");
+  EXPECT_EQ(value, "bar");
+
+  // Multiple switches with trailing spaces and tabs between them.
+  value = GetSwitchValueFromCommandLine(
+      "c:\\temp\bleh.exe --type=bar      \t\t --foo=bleh", "foo");
+  EXPECT_EQ(value, "bleh");
+}

[grt (UTC plus 2), 2016/06/15 15:49:21]

please add tests for:
- nothing after =: "c:\\temp\\bleh.exe --type="
- only whitespace after =: "c:\\temp\\bleh.exe --type= "
and any other permutations you can think of

[ananta, 2016/06/15 22:10:28]

Done.

+
 }  // namespace install_static