Add chrome_crash_reporter_client_win.cc to the source file list for chrome_elf

chrome_elf/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/win/manifest.gni")
 import("//chrome/version.gni")
 import("//testing/test.gni")
 
 process_version("chrome_elf_resources") {
   template_file = chrome_version_rc_template
   sources = [
     "chrome_elf.ver",
   ]
   output = "$target_gen_dir/chrome_elf_version.rc"
 }
 
 # This manifest matches what GYP produces. It may not even be necessary.
 windows_manifest("chrome_elf_manifest") {
   sources = [
     as_invoker_manifest,
   ]
   type = "dll"
 }
 
+# We should move chrome_result_codes.h to another target which does not bring
+# in the world.
 shared_library("chrome_elf") {
   sources = [
+    "//chrome/app/chrome_crash_reporter_client_win.cc",
+    "//chrome/app/chrome_crash_reporter_client_win.h",
+    "//chrome/common/chrome_result_codes.h",
     "chrome_elf.def",
     "chrome_elf_main.cc",
     "chrome_elf_main.h",
   ]
   deps = [
     ":blacklist",
     ":breakpad",
     ":chrome_elf_manifest",
     ":chrome_elf_resources",
     ":common",
+    "//base",
     "//build/config/sanitizers:deps",
     "//chrome/install_static:install_static_util",
+    "//components/crash/content/app",
+    "//components/crash/core/common",
+    "//content/public/common:result_codes",
   ]
   configs += [ "//build/config/win:windowed" ]
   configs -= [ "//build/config/win:console" ]
-  ldflags = [ "/NODEFAULTLIB:user32.lib" ]
+  ldflags = [
+    "/NODEFAULTLIB:user32.lib",
+    "/DELAYLOAD:dbghelp.dll",

[grt (UTC plus 2), 2016/06/14 20:07:13]

is the idea here that these are all delayloads that should never be loaded in
practice? if so, wdyt of adding a __pfnDliNotifyHook2 that CHECKs in case of an
unexpected load?

[ananta, 2016/06/14 21:27:40]

The expectation is that these dlls were load after chrome_elf, i.e a load of
chrome_elf should not cause these dlls to load via import dependencies. The dll
we are concerned about is user32 which loads global hooks, etc. I think once we
initialize crashpad in chrome_elf, we can add a check for user32 and crash
there.
Will do that in a later patch set.

+    "/DELAYLOAD:ole32.dll",
+    "/DELAYLOAD:psapi.dll",
+    "/DELAYLOAD:rpcrt4.dll",
+    "/DELAYLOAD:shell32.dll",
+    "/DELAYLOAD:user32.dll",
+    "/DELAYLOAD:winhttp.dll",
+    "/DELAYLOAD:winmm.dll",
+    "/DELAYLOAD:ws2_32.dll",
+  ]
   if (current_cpu == "x86") {
     # Don"t set an x64 base address (to avoid breaking HE-ASLR).
     ldflags += [ "/BASE:0x01c20000" ]
   }
 }
 
 source_set("constants") {
   sources = [
     "chrome_elf_constants.cc",
     "chrome_elf_constants.h",
@@ skipping 146 matching lines @@
 # which does), Ninja would get confused and always rebuild this target because
 # it sees a declared output file but that file doesn't exist on disk.
 loadable_module("blacklist_test_dll_3") {
   sources = [
     "blacklist/test/blacklist_test_dll_3.cc",
   ]
   deps = [
     "//build/config/sanitizers:deps",
   ]
 }