Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2053903003: Implement all onCreateFromStream overloads. (Closed)

Created:
4 years, 6 months ago by bungeman-skia
Modified:
4 years, 6 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Implement all onCreateFromStream overloads. The custom font manager does not implement all onCreateFromStream overloads leading to warnings. Since this needs to be implemented anyway, implement it now. BUG=skia:5412 Committed: https://skia.googlesource.com/skia/+/4772bd537d153922cd772020e4ad4820090be51a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -40 lines) Patch
M src/ports/SkFontMgr_custom.cpp View 14 chunks +55 lines, -40 lines 1 comment Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053903003/1
4 years, 6 months ago (2016-06-10 00:04:18 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-10 00:16:33 UTC) #5
bungeman-skia
https://codereview.chromium.org/2053903003/diff/1/src/ports/SkFontMgr_custom.cpp File src/ports/SkFontMgr_custom.cpp (right): https://codereview.chromium.org/2053903003/diff/1/src/ports/SkFontMgr_custom.cpp#newcode310 src/ports/SkFontMgr_custom.cpp:310: return tf; Like in the SkFontMgr_Custom constructor, this leaked ...
4 years, 6 months ago (2016-06-10 00:18:48 UTC) #8
mtklein
lgtm
4 years, 6 months ago (2016-06-10 11:13:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053903003/1
4 years, 6 months ago (2016-06-10 11:13:56 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 11:14:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4772bd537d153922cd772020e4ad4820090be51a

Powered by Google App Engine
This is Rietveld 408576698