third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp - Issue 2053903002: Returning early when setting a frame name to the same name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

Issue 2053903002: Returning early when setting a frame name to the same name. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replacing part of short-circuiting condition with just an assert. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/frames/unique-name-set-same-name-expected.txt ('k') | third_party/WebKit/Source/core/page/FrameTree.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

index 130fa525436b6c9a99074fab4f406eab4484d746..20a01b9f6b24d98edfe157a16ae76c19f7f7615c 100644

--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

@@ -1056,6 +1056,9 @@ void LocalDOMWindow::setName(const AtomicString& name)

if (!isCurrentlyDisplayedInFrame())

return;

+ if (name == frame()->tree().name())

+ return;

frame()->tree().setName(name);

ASSERT(frame()->loader().client());

frame()->loader().client()->didChangeName(name, frame()->tree().uniqueName());

dcheng 2016/06/15 11:18:35 I'd suggest moving this into FrameTree::setName()

Łukasz Anforowicz 2016/06/15 17:46:22 I think this is a great idea. At the same time, I