Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: src/compiler/arm/code-generator-arm.cc

Issue 2053893003: [builtins] Introduce proper base::ieee754::log. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: BUILD.gn Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/base/ieee754.cc ('k') | src/compiler/arm/instruction-codes-arm.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/arm/code-generator-arm.cc
diff --git a/src/compiler/arm/code-generator-arm.cc b/src/compiler/arm/code-generator-arm.cc
index 77fe2cc2a21a260f38d79744f1f8ceefad57f3a4..26ec8c5c4844158529894a4c12b475ac8e8da691 100644
--- a/src/compiler/arm/code-generator-arm.cc
+++ b/src/compiler/arm/code-generator-arm.cc
@@ -674,6 +674,19 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
__ add(i.OutputRegister(0), base, Operand(offset.offset()));
break;
}
+ case kIeee754Float64Log: {
+ // TODO(bmeurer): We should really get rid of this special instruction,
+ // and generate a CallAddress instruction instead.
+ FrameScope scope(masm(), StackFrame::MANUAL);
+ __ PrepareCallCFunction(0, 1, kScratchReg);
+ __ MovToFloatParameter(i.InputFloat64Register(0));
+ __ CallCFunction(ExternalReference::ieee754_log_function(isolate()), 0,
+ 1);
+ // Move the result in the double result register.
+ __ MovFromFloatResult(i.OutputFloat64Register());
+ DCHECK_EQ(LeaveCC, i.OutputSBit());
+ break;
+ }
case kArmAdd:
__ add(i.OutputRegister(), i.InputRegister(0), i.InputOperand2(1),
i.OutputSBit());
@@ -998,19 +1011,6 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
DCHECK_EQ(LeaveCC, i.OutputSBit());
break;
}
- case kArmVlogF64: {
- // TODO(bmeurer): We should really get rid of this special instruction,
- // and generate a CallAddress instruction instead.
- FrameScope scope(masm(), StackFrame::MANUAL);
- __ PrepareCallCFunction(0, 1, kScratchReg);
- __ MovToFloatParameter(i.InputFloat64Register(0));
- __ CallCFunction(ExternalReference::math_log_double_function(isolate()),
- 0, 1);
- // Move the result in the double result register.
- __ MovFromFloatResult(i.OutputFloat64Register());
- DCHECK_EQ(LeaveCC, i.OutputSBit());
- break;
- }
case kArmVsqrtF64:
__ vsqrt(i.OutputFloat64Register(), i.InputFloat64Register(0));
break;
« no previous file with comments | « src/base/ieee754.cc ('k') | src/compiler/arm/instruction-codes-arm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698