Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2053843002: Cleanup some cjs_runtime ifdefs. (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Cleanup some cjs_runtime ifdefs. Shuffle the code around to make it easier to follow what the ifdefs are doing. Committed: https://pdfium.googlesource.com/pdfium/+/d71bae02d83c4b9594336efdedc714bcd5c18ab7

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -25 lines) Patch
M fpdfsdk/javascript/cjs_runtime.cpp View 1 7 chunks +16 lines, -25 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dsinclair
PTAL.
4 years, 6 months ago (2016-06-09 20:41:18 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/2053843002/diff/1/fpdfsdk/javascript/cjs_runtime.cpp File fpdfsdk/javascript/cjs_runtime.cpp (right): https://codereview.chromium.org/2053843002/diff/1/fpdfsdk/javascript/cjs_runtime.cpp#newcode68 fpdfsdk/javascript/cjs_runtime.cpp:68: nit: no blank line here.
4 years, 6 months ago (2016-06-09 21:07:15 UTC) #3
dsinclair
https://codereview.chromium.org/2053843002/diff/1/fpdfsdk/javascript/cjs_runtime.cpp File fpdfsdk/javascript/cjs_runtime.cpp (right): https://codereview.chromium.org/2053843002/diff/1/fpdfsdk/javascript/cjs_runtime.cpp#newcode68 fpdfsdk/javascript/cjs_runtime.cpp:68: On 2016/06/09 21:07:15, Tom Sepez wrote: > nit: no ...
4 years, 6 months ago (2016-06-09 21:09:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053843002/20001
4 years, 6 months ago (2016-06-09 21:09:46 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 21:21:23 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/d71bae02d83c4b9594336efdedc714bcd5c1...

Powered by Google App Engine
This is Rietveld 408576698