Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: platform_tools/android/gyp_gen/makefile_writer.py

Issue 205383006: Add tests for makefile_writer.py. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Check test results to return non zero on failure. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | platform_tools/android/tests/expectations/Android.mk » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: platform_tools/android/gyp_gen/makefile_writer.py
diff --git a/platform_tools/android/gyp_gen/makefile_writer.py b/platform_tools/android/gyp_gen/makefile_writer.py
index 791d225f8b89328c5d6a298f069c8149317fe25e..ea767f6958de95223d59732a0437cb877e702bd2 100644
--- a/platform_tools/android/gyp_gen/makefile_writer.py
+++ b/platform_tools/android/gyp_gen/makefile_writer.py
@@ -11,7 +11,6 @@ Functions for creating an Android.mk from already created dictionaries.
import os
-# TODO(scroggo): Add unit tests for this file.
def write_group(f, name, items, append):
"""
Helper function to list all names passed to a variable.
« no previous file with comments | « no previous file | platform_tools/android/tests/expectations/Android.mk » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698