platform_tools/android/gyp_gen/makefile_writer.py - Issue 205383006: Add tests for makefile_writer.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: platform_tools/android/gyp_gen/makefile_writer.py

Issue 205383006: Add tests for makefile_writer.py. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: platform_tools/android/gyp_gen/makefile_writer.py

diff --git a/platform_tools/android/gyp_gen/makefile_writer.py b/platform_tools/android/gyp_gen/makefile_writer.py

index 791d225f8b89328c5d6a298f069c8149317fe25e..ea767f6958de95223d59732a0437cb877e702bd2 100644

--- a/platform_tools/android/gyp_gen/makefile_writer.py

+++ b/platform_tools/android/gyp_gen/makefile_writer.py

@@ -11,7 +11,6 @@ Functions for creating an Android.mk from already created dictionaries.

import os

-# TODO(scroggo): Add unit tests for this file.

def write_group(f, name, items, append):

"""

Helper function to list all names passed to a variable.