Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2053823002: Make SkBlitter hierarchy explicit about what needs to be implemented. (Closed)

Created:
4 years, 6 months ago by herb_g
Modified:
4 years, 6 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make SkBlitter hierarchy explicit about what needs to be implemented. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2053823002 Committed: https://skia.googlesource.com/skia/+/7df9e4a87d84415391c167ea54cd389d4b423c2d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -33 lines) Patch
M src/core/SkBlitter.h View 2 chunks +6 lines, -3 lines 0 comments Download
M src/core/SkBlitter.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkBlitter_Sprite.cpp View 4 chunks +18 lines, -8 lines 0 comments Download
M src/core/SkLinearBitmapPipeline_sample.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkRegion_path.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkSpriteBlitter.h View 2 chunks +10 lines, -2 lines 0 comments Download
M tests/BlitMaskClip.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/FillPathTest.cpp View 1 chunk +23 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053823002/1
4 years, 6 months ago (2016-06-09 20:26:33 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-09 20:47:32 UTC) #5
herb_g
This is the first part of understanding SkBlitters. The runs documentation will follow in the ...
4 years, 6 months ago (2016-06-10 15:54:49 UTC) #6
reed1
lgtm
4 years, 6 months ago (2016-06-10 19:46:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053823002/1
4 years, 6 months ago (2016-06-10 20:00:33 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 20:01:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7df9e4a87d84415391c167ea54cd389d4b423c2d

Powered by Google App Engine
This is Rietveld 408576698