Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1163)

Issue 2053793002: Attempt to deflake video-layer-crash.html. (Closed)

Created:
4 years, 6 months ago by jbroman
Modified:
4 years, 6 months ago
Reviewers:
xidachen
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Attempt to deflake video-layer-crash.html. This makes the test wait for layout and paint, instead of finishing the test as soon as the seeked event is seen. Currently the Retina bot flakily produces the frame previous to the one that is expected. BUG=618693 Committed: https://crrev.com/4990c8699c14f2c7226b901c11ea45a810d93c63 Cr-Commit-Position: refs/heads/master@{#399010}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/media/video-paint-test.js View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jbroman
PTAL. I'd like to land this, but it's a fairly speculative fix (since I don't ...
4 years, 6 months ago (2016-06-09 20:04:08 UTC) #2
xidachen
lgtm
4 years, 6 months ago (2016-06-09 20:06:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053793002/1
4 years, 6 months ago (2016-06-09 20:07:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 20:55:15 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-09 20:55:21 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4990c8699c14f2c7226b901c11ea45a810d93c63 Cr-Commit-Position: refs/heads/master@{#399010}
4 years, 6 months ago (2016-06-09 20:57:49 UTC) #9
jbroman
4 years, 6 months ago (2016-06-10 15:36:58 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2057193002/ by jbroman@chromium.org.

The reason for reverting is: Didn't deflake -- and there should be a synchronous
layout/paint before pixel dump anyhow..

Powered by Google App Engine
This is Rietveld 408576698