Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2053723002: MD User Manager: Overhaul Urls (Closed)

Created:
4 years, 6 months ago by Moe
Modified:
4 years, 6 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, michaelpg+watch-md-ui_chromium.org, pam+watch_chromium.org, rginda+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@md-user-manager-locked-dialogs
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD User Manager: Overhaul Urls 1. Uses relative Urls for the user manager resources. 2. Inlines css for user_manager.html. 2. Only flattens files that need to be flattened. 3. Fixes iron-flex-layout warnings. BUG=563722 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e655e9fab57bc45174ff451e06ad3511eaf0c16c Cr-Commit-Position: refs/heads/master@{#399169}

Patch Set 1 : Initial #

Patch Set 2 : Changed Urls for html resources to root-relative Urls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -345 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +13 lines, -14 lines 0 comments Download
M chrome/browser/resources/md_user_manager/control_bar.html View 1 3 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/resources/md_user_manager/create_profile.html View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_user_manager/error_dialog.html View 1 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_user_manager/import_supervised_user.html View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_user_manager/profile_browser_proxy.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_user_manager/shared_styles.html View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_user_manager/strings.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_user_manager/supervised_user_create_confirm.html View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/md_user_manager/supervised_user_learn_more.html View 1 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_user_manager/user_manager.html View 1 2 chunks +276 lines, -10 lines 0 comments Download
M chrome/browser/resources/md_user_manager/user_manager_dialog.html View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_user_manager/user_manager_pages.html View 1 2 chunks +4 lines, -4 lines 0 comments Download
D chrome/browser/resources/md_user_manager/user_manager_styles.html View 1 chunk +0 lines, -272 lines 0 comments Download
M chrome/browser/resources/md_user_manager/user_manager_tutorial.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/md_user_manager_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Moe
Hi Demeterios, Please review this CL.
4 years, 6 months ago (2016-06-09 17:40:20 UTC) #6
dpapad
LGTM as long as it works.
4 years, 6 months ago (2016-06-09 18:23:42 UTC) #7
Moe
On 2016/06/09 18:23:42, dpapad wrote: > LGTM as long as it works. Thanks Demetrios. I ...
4 years, 6 months ago (2016-06-09 21:45:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053723002/40001
4 years, 6 months ago (2016-06-09 21:46:19 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/125263)
4 years, 6 months ago (2016-06-10 00:36:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053723002/40001
4 years, 6 months ago (2016-06-10 13:10:11 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-10 13:14:06 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 13:14:13 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 13:15:37 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e655e9fab57bc45174ff451e06ad3511eaf0c16c
Cr-Commit-Position: refs/heads/master@{#399169}

Powered by Google App Engine
This is Rietveld 408576698