Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2053713002: Turn on the BackgroundScheduler test that was flaky, so we can (Closed)

Created:
4 years, 6 months ago by Pete Williamson
Modified:
4 years, 6 months ago
Reviewers:
dougarnett
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn on the BackgroundScheduler test that was flaky, so we can test a fix on trybots. BUG=612325 Committed: https://crrev.com/90704f1b454acae760b88738f8652864a9575b92 Cr-Commit-Position: refs/heads/master@{#399244}

Patch Set 1 #

Patch Set 2 : Trying with a static method #

Patch Set 3 : remove commented out code #

Total comments: 2

Patch Set 4 : Remove unused @Config() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/ShadowGcmNetworkManager.java View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (9 generated)
Pete Williamson
4 years, 6 months ago (2016-06-10 01:00:32 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053713002/40001
4 years, 6 months ago (2016-06-10 01:00:51 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ...
4 years, 6 months ago (2016-06-10 03:03:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053713002/40001
4 years, 6 months ago (2016-06-10 16:27:35 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-10 16:27:37 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053713002/40001
4 years, 6 months ago (2016-06-10 16:30:52 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-10 16:35:59 UTC) #14
dougarnett
https://codereview.chromium.org/2053713002/diff/40001/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java File chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java (right): https://codereview.chromium.org/2053713002/diff/40001/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java#newcode37 chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java:37: @Config() btw, don't think you need this now - ...
4 years, 6 months ago (2016-06-10 17:00:05 UTC) #15
Pete Williamson
https://codereview.chromium.org/2053713002/diff/40001/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java File chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java (right): https://codereview.chromium.org/2053713002/diff/40001/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java#newcode37 chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundSchedulerTest.java:37: @Config() On 2016/06/10 17:00:05, dougarnett wrote: > btw, don't ...
4 years, 6 months ago (2016-06-10 17:49:18 UTC) #16
dougarnett
lgtm
4 years, 6 months ago (2016-06-10 18:14:51 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053713002/60001
4 years, 6 months ago (2016-06-10 18:16:15 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-10 18:52:07 UTC) #20
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 18:52:10 UTC) #21
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 18:54:08 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/90704f1b454acae760b88738f8652864a9575b92
Cr-Commit-Position: refs/heads/master@{#399244}

Powered by Google App Engine
This is Rietveld 408576698