Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2053683002: SkColorSpace::NewICC fix integer overflow caught by fuzzer (Closed)

Created:
4 years, 6 months ago by msarett
Modified:
4 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkColorSpace::NewICC fix integer overflow caught by fuzzer BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2053683002 Committed: https://skia.googlesource.com/skia/+/8c5424cb77f842113213c52854b17f14f7f3881d

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M src/core/SkColorSpace.cpp View 4 chunks +20 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
msarett
4 years, 6 months ago (2016-06-09 13:12:26 UTC) #4
msarett
I've verified that this fixes the set of test cases posted on Drive.
4 years, 6 months ago (2016-06-09 13:14:42 UTC) #5
kjlubick
lgtm
4 years, 6 months ago (2016-06-09 13:17:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053683002/20001
4 years, 6 months ago (2016-06-09 13:17:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001) as https://skia.googlesource.com/skia/+/8c5424cb77f842113213c52854b17f14f7f3881d
4 years, 6 months ago (2016-06-09 13:33:22 UTC) #10
reed1
4 years, 6 months ago (2016-06-09 13:42:41 UTC) #12
Message was sent while issue was closed.
Seems like we have (separately) writing utilities to perform "safe" math on
size_t multiple times in multiple files... Can we collect them so that the next
N fuzzer fixes can go faster (and be more readable)?

Powered by Google App Engine
This is Rietveld 408576698