Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2053673002: Move Fullscreen static helpers to an anonymous namespace (Closed)

Created:
4 years, 6 months ago by foolip
Modified:
4 years, 6 months ago
Reviewers:
alexmos
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Fullscreen static helpers to an anonymous namespace R=alexmos@chromium.org Committed: https://crrev.com/ce7c5e95806e6963ae33946c8e4399920986bc03 Cr-Commit-Position: refs/heads/master@{#398889}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M third_party/WebKit/Source/core/dom/Fullscreen.cpp View 4 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
foolip
4 years, 6 months ago (2016-06-09 12:43:36 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053673002/1
4 years, 6 months ago (2016-06-09 12:43:42 UTC) #3
foolip
Noticed in https://codereview.chromium.org/2040973003/ that this wasn't using the hip new way like HTMLMediaElement does. I ...
4 years, 6 months ago (2016-06-09 12:44:41 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-09 14:06:55 UTC) #6
alexmos
On 2016/06/09 12:44:41, Philip Jägenstedt wrote: > Noticed in https://codereview.chromium.org/2040973003/ that this wasn't using > ...
4 years, 6 months ago (2016-06-09 15:17:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053673002/1
4 years, 6 months ago (2016-06-09 15:18:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 15:23:02 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 15:25:02 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce7c5e95806e6963ae33946c8e4399920986bc03
Cr-Commit-Position: refs/heads/master@{#398889}

Powered by Google App Engine
This is Rietveld 408576698