Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2053633003: Makes views example copy content_resources.pak (Closed)

Created:
4 years, 6 months ago by sky
Modified:
4 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes views example copy content_resources.pak This way it can actually load it, which it is trying to do now but crashing. BUG=618748 TEST=none R=brettw@chromium.org Committed: https://crrev.com/b5a4de34e62e7ac2cebc38fe09e22d7605daec4d Cr-Commit-Position: refs/heads/master@{#400243}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M ui/views/examples/BUILD.gn View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 6 months ago (2016-06-09 19:42:46 UTC) #1
brettw
lgtm
4 years, 6 months ago (2016-06-16 18:26:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053633003/1
4 years, 6 months ago (2016-06-16 19:02:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-16 20:11:16 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 20:13:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5a4de34e62e7ac2cebc38fe09e22d7605daec4d
Cr-Commit-Position: refs/heads/master@{#400243}

Powered by Google App Engine
This is Rietveld 408576698