Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2053633002: [WebView] Unbreak layout tests on the Android WebView L/M bots. (Closed)

Created:
4 years, 6 months ago by timvolodine
Modified:
4 years, 6 months ago
Reviewers:
whywhat, Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebView] Unbreak layout tests on the Android WebView L/M bots. Add the "window.chrome" attribute to excluded interfaces for WebView. BUG=618471 TBR=torne@chromium.org NOTRY=true Committed: https://crrev.com/9b2cc9a2b30067cbbd3327ad9d1a2ebcb930dbaa Cr-Commit-Position: refs/heads/master@{#398846}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
timvolodine
4 years, 6 months ago (2016-06-09 11:35:27 UTC) #2
Torne
lgtm
4 years, 6 months ago (2016-06-09 11:40:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053633002/1
4 years, 6 months ago (2016-06-09 11:50:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 11:54:53 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 11:57:38 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b2cc9a2b30067cbbd3327ad9d1a2ebcb930dbaa
Cr-Commit-Position: refs/heads/master@{#398846}

Powered by Google App Engine
This is Rietveld 408576698