chrome/browser/notifications/notification_platform_bridge_mac.mm - Issue 2053613002: Make the notification builder more XPC friendly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_platform_bridge_mac.mm

Issue 2053613002: Make the notification builder more XPC friendly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert unintended change Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/notification_platform_bridge_mac.mm

diff --git a/chrome/browser/notifications/notification_platform_bridge_mac.mm b/chrome/browser/notifications/notification_platform_bridge_mac.mm

index 3b1832c470e3a3dc92bb78805187c3dda37c80ec..98272de91daacc9b662f1ce97848b4944d8a3fbb 100644

--- a/chrome/browser/notifications/notification_platform_bridge_mac.mm

+++ b/chrome/browser/notifications/notification_platform_bridge_mac.mm

@@ -12,12 +12,12 @@

#include "base/strings/sys_string_conversions.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/notifications/notification.h"

-#include "chrome/browser/notifications/notification_builder_mac.h"

#include "chrome/browser/notifications/notification_display_service_factory.h"

#include "chrome/browser/notifications/persistent_notification_delegate.h"

#include "chrome/browser/notifications/platform_notification_service_impl.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/profiles/profile_manager.h"

+#include "chrome/browser/ui/cocoa/notifications/notification_builder_mac.h"

#include "chrome/grit/generated_resources.h"

#include "components/url_formatter/elide_url.h"

#include "third_party/WebKit/public/platform/modules/notifications/WebNotificationConstants.h"

@@ -135,7 +135,6 @@ void NotificationPlatformBridgeMac::Display(const std::string& notification_id,

[builder setIncognito:incognito];

NSUserNotification* toast = [builder buildUserNotification];

[notification_center_ deliverNotification:toast];

}