Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm

Issue 2053613002: Make the notification builder more XPC friendly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revert unintended change Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <AppKit/AppKit.h> 5 #import <AppKit/AppKit.h>
6 6
7 #include "base/mac/foundation_util.h" 7 #include "base/mac/foundation_util.h"
8 #include "base/mac/scoped_nsobject.h" 8 #include "base/mac/scoped_nsobject.h"
9 #include "base/strings/sys_string_conversions.h" 9 #include "base/strings/sys_string_conversions.h"
10 #include "chrome/browser/notifications/notification_builder_mac.h" 10 #include "chrome/browser/ui/cocoa/notifications/notification_builder_mac.h"
11 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
12 12
13 TEST(NotificationBuilderMacTest, TestNotificationNoButtons) { 13 TEST(NotificationBuilderMacTest, TestNotificationNoButtons) {
14 base::scoped_nsobject<NotificationBuilder> builder( 14 base::scoped_nsobject<NotificationBuilder> builder(
15 [[NotificationBuilder alloc] init]); 15 [[NotificationBuilder alloc] init]);
16 [builder setTitle:@"Title"]; 16 [builder setTitle:@"Title"];
17 [builder setSubTitle:@"https://www.miguel.com"]; 17 [builder setSubTitle:@"https://www.miguel.com"];
18 [builder setContextMessage:@""]; 18 [builder setContextMessage:@""];
19 [builder setTag:@"tag1"]; 19 [builder setTag:@"tag1"];
20 [builder setIcon:[NSImage imageNamed:@"NSApplicationIcon"]]; 20 [builder setIcon:[NSImage imageNamed:@"NSApplicationIcon"]];
(...skipping 19 matching lines...) Expand all
40 base::scoped_nsobject<NotificationBuilder> builder( 40 base::scoped_nsobject<NotificationBuilder> builder(
41 [[NotificationBuilder alloc] init]); 41 [[NotificationBuilder alloc] init]);
42 [builder setTitle:@"Title"]; 42 [builder setTitle:@"Title"];
43 [builder setSubTitle:@"https://www.miguel.com"]; 43 [builder setSubTitle:@"https://www.miguel.com"];
44 [builder setContextMessage:@"SubTitle"]; 44 [builder setContextMessage:@"SubTitle"];
45 [builder setButtons:@"Button1" secondaryButton:@""]; 45 [builder setButtons:@"Button1" secondaryButton:@""];
46 [builder setNotificationId:@"notificationId"]; 46 [builder setNotificationId:@"notificationId"];
47 [builder setProfileId:@"profileId"]; 47 [builder setProfileId:@"profileId"];
48 [builder setIncognito:false]; 48 [builder setIncognito:false];
49 49
50 NSUserNotification* notification = [builder buildUserNotification]; 50 NSUserNotification* notification = [builder buildUserNotification];
51 51
52 EXPECT_EQ("Title", base::SysNSStringToUTF8([notification title])); 52 EXPECT_EQ("Title", base::SysNSStringToUTF8([notification title]));
53 EXPECT_EQ("SubTitle", 53 EXPECT_EQ("SubTitle",
54 base::SysNSStringToUTF8([notification informativeText])); 54 base::SysNSStringToUTF8([notification informativeText]));
55 EXPECT_EQ("https://www.miguel.com", 55 EXPECT_EQ("https://www.miguel.com",
56 base::SysNSStringToUTF8([notification subtitle])); 56 base::SysNSStringToUTF8([notification subtitle]));
57 57
58 EXPECT_TRUE([notification hasActionButton]); 58 EXPECT_TRUE([notification hasActionButton]);
59 59
60 EXPECT_EQ("Options", 60 EXPECT_EQ("Options",
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 [[NotificationBuilder alloc] initWithDictionary:notificationData]); 143 [[NotificationBuilder alloc] initWithDictionary:notificationData]);
144 144
145 NSUserNotification* notification = [finalBuilder buildUserNotification]; 145 NSUserNotification* notification = [finalBuilder buildUserNotification];
146 146
147 EXPECT_EQ("Title", base::SysNSStringToUTF8([notification title])); 147 EXPECT_EQ("Title", base::SysNSStringToUTF8([notification title]));
148 EXPECT_EQ("SubTitle", 148 EXPECT_EQ("SubTitle",
149 base::SysNSStringToUTF8([notification informativeText])); 149 base::SysNSStringToUTF8([notification informativeText]));
150 EXPECT_EQ("https://www.miguel.com", 150 EXPECT_EQ("https://www.miguel.com",
151 base::SysNSStringToUTF8([notification subtitle])); 151 base::SysNSStringToUTF8([notification subtitle]));
152 } 152 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698