Make the notification builder more XPC friendly

chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "chrome/browser/notifications/notification_builder_mac.h"
+#import "chrome/browser/ui/cocoa/notifications/notification_builder_mac.h"
 
 #import <AppKit/AppKit.h>
 
 #include "base/mac/mac_util.h"
 #include "base/mac/scoped_nsobject.h"
 #include "chrome/grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 
 namespace {
 
 // Internal builder constants representing the different notification fields
 // They don't need to be exposed outside the builder.
 
 NSString* const kNotificationTitle = @"title";
 NSString* const kNotificationSubTitle = @"subtitle";
 NSString* const kNotificationInformativeText = @"informativeText";
 NSString* const kNotificationImage = @"icon";
 NSString* const kNotificationButtonOne = @"buttonOne";
 NSString* const kNotificationButtonTwo = @"buttonTwo";
 NSString* const kNotificationTag = @"tag";
-
+NSString* const kNotificationCloseButtonTag = @"closeButton";
+NSString* const kNotificationOptionsButtonTag = @"optionsButton";
+NSString* const kNotificationSettingsButtonTag = @"settingsButton";
 }  // namespace
 
 namespace notification_builder {
 
 // Exposed constants to include user related data in the notification.
 NSString* const kNotificationOrigin = @"notificationOrigin";
 NSString* const kNotificationId = @"notificationId";
 NSString* const kNotificationProfileId = @"notificationProfileId";
 NSString* const kNotificationIncognito = @"notificationIncognito";
 
 }  // namespace notification_builder
 
 @implementation NotificationBuilder {
   base::scoped_nsobject<NSMutableDictionary> notificationData_;
 }
 
 - (instancetype)init {
   if ((self = [super init])) {
     notificationData_.reset([[NSMutableDictionary alloc] init]);
+    [notificationData_
+        setObject:l10n_util::GetNSString(IDS_NOTIFICATION_BUTTON_CLOSE)
+           forKey:kNotificationCloseButtonTag];
+    [notificationData_
+        setObject:l10n_util::GetNSString(IDS_NOTIFICATION_BUTTON_OPTIONS)
+           forKey:kNotificationOptionsButtonTag];
+    [notificationData_
+        setObject:l10n_util::GetNSString(IDS_NOTIFICATION_BUTTON_SETTINGS)
+           forKey:kNotificationSettingsButtonTag];
   }
   return self;
 }
 
 - (instancetype)initWithDictionary:(NSDictionary*)data {
   if ((self = [super init])) {
     notificationData_.reset([data copy]);
   }
   return self;
 }
@@ skipping 68 matching lines @@
   if ([notificationData_ objectForKey:kNotificationImage]) {
     if ([toast respondsToSelector:@selector(_identityImage)]) {
       NSImage* image = [notificationData_ objectForKey:kNotificationImage];
       [toast setValue:image forKey:@"_identityImage"];
       [toast setValue:@NO forKey:@"_identityImageHasBorder"];
     }
   }
 
   // Buttons
   if ([toast respondsToSelector:@selector(_showsButtons)]) {
+    DCHECK([notificationData_ objectForKey:kNotificationCloseButtonTag]);
+    DCHECK([notificationData_ objectForKey:kNotificationSettingsButtonTag]);
+    DCHECK([notificationData_ objectForKey:kNotificationOptionsButtonTag]);
+
     [toast setValue:@YES forKey:@"_showsButtons"];
     // A default close button label is provided by the platform but we
     // explicitly override it in case the user decides to not
     // use the OS language in Chrome.
-    [toast setOtherButtonTitle:l10n_util::GetNSString(
-                                   IDS_NOTIFICATION_BUTTON_CLOSE)];
+    [toast setOtherButtonTitle:[notificationData_
+                                   objectForKey:kNotificationCloseButtonTag]];
 
     // Display the Settings button as the action button if there are either no
     // developer-provided action buttons, or the alternate action menu is not
     // available on this Mac version. This avoids needlessly showing the menu.
     // TODO(miguelg): Extensions should not have a settings button.
     if (![notificationData_ objectForKey:kNotificationButtonOne] ||
         ![toast respondsToSelector:@selector(_alwaysShowAlternateActionMenu)]) {
-      [toast setActionButtonTitle:l10n_util::GetNSString(
-                                      IDS_NOTIFICATION_BUTTON_SETTINGS)];
+      [toast
+          setActionButtonTitle:
+              [notificationData_ objectForKey:kNotificationSettingsButtonTag]];
     } else {
       // Otherwise show the alternate menu, then show the developer actions and
       // finally the settings one.
       DCHECK(
           [toast respondsToSelector:@selector(_alwaysShowAlternateActionMenu)]);
       DCHECK(
           [toast respondsToSelector:@selector(_alternateActionButtonTitles)]);
-      [toast setActionButtonTitle:l10n_util::GetNSString(
-                                      IDS_NOTIFICATION_BUTTON_OPTIONS)];
+      [toast
+          setActionButtonTitle:[notificationData_
+                                   objectForKey:kNotificationOptionsButtonTag]];
       [toast setValue:@YES forKey:@"_alwaysShowAlternateActionMenu"];
 
       NSMutableArray* buttons = [NSMutableArray arrayWithCapacity:3];
       [buttons
           addObject:[notificationData_ objectForKey:kNotificationButtonOne]];
       if ([notificationData_ objectForKey:kNotificationButtonTwo]) {
         [buttons
             addObject:[notificationData_ objectForKey:kNotificationButtonTwo]];
       }
-      [buttons
-          addObject:l10n_util::GetNSString(IDS_NOTIFICATION_BUTTON_SETTINGS)];
+      [buttons addObject:[notificationData_
+                             objectForKey:kNotificationSettingsButtonTag]];
       [toast setValue:buttons forKey:@"_alternateActionButtonTitles"];
     }
   }
 
   // Tag
   if ([toast respondsToSelector:@selector(setIdentifier:)] &&
       [notificationData_ objectForKey:kNotificationTag]) {
     [toast setValue:[notificationData_ objectForKey:kNotificationTag]
              forKey:@"identifier"];
   }
@@ skipping 26 matching lines @@
   };
 
   return toast.autorelease();
 }
 
 - (NSDictionary*)buildDictionary {
   return [[notificationData_ copy] autorelease];
 }
 
 @end