build_overrides/v8.gni - Issue 2053603002: Roll V8 and its deps and update ICU initialization call

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build_overrides/v8.gni

Issue 2053603002: Roll V8 and its deps and update ICU initialization call (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: updates Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build_overrides/v8.gni

diff --git a/build_overrides/v8.gni b/build_overrides/v8.gni

index 2b50795fd6b93d4087095daf95b5ce1589a242a2..969b6aa654261fb55d0c8333b66ddef6d765f80f 100644

--- a/build_overrides/v8.gni

+++ b/build_overrides/v8.gni

@@ -6,8 +6,10 @@ if (is_android) {

import("//build/config/android/config.gni")

}

+v8_use_external_startup_data = !is_ios

Michael Achenbach 2016/06/09 09:34:46 v8_use_external_startup_data and v8_optimized_debu

+# Turns on compiler optimizations in V8 in Debug build.

v8_optimized_debug = true

-v8_use_external_startup_data = false

# V8 extras

# Adding V8 extras files requires API owners review

« no previous file with comments | « DEPS ('k') | samples/pdfium_test.cc » ('j') | no next file with comments »