Issue 20536: Add test to check that RegExp-ia32 can survive a garbage collection during execution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20536: Add test to check that RegExp-ia32 can survive a garbage collection during execution. (Closed)

Created:
11 years, 10 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Add test for GC during RegExp. Fix bug found by test.

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+126 lines, -5 lines)			Patch
M	src/regexp-macro-assembler-ia32.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/regexp-macro-assembler-ia32.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+120 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Erik Corry

LGTM. It would be nice to see more variety in the regexps run. For example ...

11 years, 10 months ago (2009-02-20 12:54:27 UTC) #2

Lasse Reichstein

More varienty is a good idea. I'll leave it for another changelist for now.

11 years, 10 months ago (2009-02-20 13:02:35 UTC) #3

Lasse Reichstein

11 years, 10 months ago (2009-02-20 13:02:36 UTC) #4

More varienty is a good idea. I'll leave it for another changelist for now.