xfa_fm2jscontext method cleanup - pt IX of IX

xfa_fm2jscontext method cleanup - pt IX of IX

Clean up ::ExtractDouble, ::ValueToDouble, ::ValueToFloat, ::ValueToInteger,
::ParseResolveResult, ::ResolveObjects, ::GetObjectByName, ::unfoldArgs,
::simpleValueCompare, ::ValueIsNull, ::concat_fm_object, ::fm_var_filter,
::get_fm_value, ::is_fm_array, ::is_fm_object, ::eval_translation,
::dotdot_accessor and ::dot_accessor

Committed: https://pdfium.googlesource.com/pdfium/+/bd136fb1ad8faa377bee0982ee9ef09d150ce6ca

[dsinclair, 2016-06-09 14:23:42]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-06-09 14:23:43]

PTAL.

[dsinclair, 2016-06-09 15:00:15]

Description was changed from

==========
xfa_fm2jscontext method cleanup - pt IX of IX

Clean up ::ExtractDouble, ::ValueToDouble, ::ValueToFloat, ::ValueToInteger,
::ParseResolveResult, ::ResolveObjects, ::GetObjectByName, ::unfoldArgs,
::simpleValueCompare, ::ValueIsNull, ::concat_fm_object, ::fm_var_filter,
::get_fm_value, ::is_fm_array, ::is_fm_object, ::eval_translation,
::dotdot_accessor and ::dot_accessor

BUG=
==========

to

==========
xfa_fm2jscontext method cleanup - pt IX of IX

Clean up ::ExtractDouble, ::ValueToDouble, ::ValueToFloat, ::ValueToInteger,
::ParseResolveResult, ::ResolveObjects, ::GetObjectByName, ::unfoldArgs,
::simpleValueCompare, ::ValueIsNull, ::concat_fm_object, ::fm_var_filter,
::get_fm_value, ::is_fm_array, ::is_fm_object, ::eval_translation,
::dotdot_accessor and ::dot_accessor
==========

[Tom Sepez, 2016-06-09 18:15:56]

lgtm

This is getting so much better.

https://codereview.chromium.org/2053583003/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
File xfa/fxfa/fm2js/xfa_fm2jscontext.cpp (right):

https://codereview.chromium.org/2053583003/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:5522:
pContext->ThrowException(XFA_IDS_COMPILER_ERROR);
nit: Is this the right error?  I thought the others threw something else.  We
might want to make this consistent throughout.

https://codereview.chromium.org/2053583003/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:5531: iIndexValue = ValueToInteger(pThis,
argIndex.get());
nit: local not needed, just args.GetValue(4).get()

https://codereview.chromium.org/2053583003/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:5677: iIndexValue = ValueToInteger(pThis,
argIndex.get());
nitto

[dsinclair, 2016-06-09 18:23:59]

https://codereview.chromium.org/2053583003/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
File xfa/fxfa/fm2js/xfa_fm2jscontext.cpp (right):

https://codereview.chromium.org/2053583003/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:5522:
pContext->ThrowException(XFA_IDS_COMPILER_ERROR);
On 2016/06/09 18:15:56, Tom Sepez wrote:
> nit: Is this the right error?  I thought the others threw something else.  We
> might want to make this consistent throughout.


I think this makes sense. In the cases above here we have methods that the user
would call Post(), Get(), etc. With the methods returning COMPILER_ERROR we have
operators so dot_accessor, assign_value_operator and those are more like
compiler errors.

https://codereview.chromium.org/2053583003/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:5531: iIndexValue = ValueToInteger(pThis,
argIndex.get());
On 2016/06/09 18:15:56, Tom Sepez wrote:
> nit: local not needed, just args.GetValue(4).get()

Done.

https://codereview.chromium.org/2053583003/diff/1/xfa/fxfa/fm2js/xfa_fm2jscon...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:5677: iIndexValue = ValueToInteger(pThis,
argIndex.get());
On 2016/06/09 18:15:56, Tom Sepez wrote:
> nitto

Done.

[dsinclair, 2016-06-09 18:24:46]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-06-09 18:24:47]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2053583003/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-06-09 18:25:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2053583003/20001

[commit-bot: I haz the power, 2016-06-09 18:47:55]

Description was changed from

==========
xfa_fm2jscontext method cleanup - pt IX of IX

Clean up ::ExtractDouble, ::ValueToDouble, ::ValueToFloat, ::ValueToInteger,
::ParseResolveResult, ::ResolveObjects, ::GetObjectByName, ::unfoldArgs,
::simpleValueCompare, ::ValueIsNull, ::concat_fm_object, ::fm_var_filter,
::get_fm_value, ::is_fm_array, ::is_fm_object, ::eval_translation,
::dotdot_accessor and ::dot_accessor
==========

to

==========
xfa_fm2jscontext method cleanup - pt IX of IX

Clean up ::ExtractDouble, ::ValueToDouble, ::ValueToFloat, ::ValueToInteger,
::ParseResolveResult, ::ResolveObjects, ::GetObjectByName, ::unfoldArgs,
::simpleValueCompare, ::ValueIsNull, ::concat_fm_object, ::fm_var_filter,
::get_fm_value, ::is_fm_array, ::is_fm_object, ::eval_translation,
::dotdot_accessor and ::dot_accessor

Committed:
https://pdfium.googlesource.com/pdfium/+/bd136fb1ad8faa377bee0982ee9ef09d150c...
==========

[commit-bot: I haz the power, 2016-06-09 18:47:56]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/bd136fb1ad8faa377bee0982ee9ef09d150c...