Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: src/code-stubs.h

Issue 2053583002: [ic] Don't pollute per-map code cache with CompareIC stubs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/code-stubs.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_CODE_STUBS_H_ 5 #ifndef V8_CODE_STUBS_H_
6 #define V8_CODE_STUBS_H_ 6 #define V8_CODE_STUBS_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/assembler.h" 9 #include "src/assembler.h"
10 #include "src/code-stub-assembler.h" 10 #include "src/code-stub-assembler.h"
(...skipping 2028 matching lines...) Expand 10 before | Expand all | Expand 10 after
2039 void GenerateStrings(MacroAssembler* masm); 2039 void GenerateStrings(MacroAssembler* masm);
2040 void GenerateUniqueNames(MacroAssembler* masm); 2040 void GenerateUniqueNames(MacroAssembler* masm);
2041 void GenerateReceivers(MacroAssembler* masm); 2041 void GenerateReceivers(MacroAssembler* masm);
2042 void GenerateMiss(MacroAssembler* masm); 2042 void GenerateMiss(MacroAssembler* masm);
2043 void GenerateKnownReceivers(MacroAssembler* masm); 2043 void GenerateKnownReceivers(MacroAssembler* masm);
2044 void GenerateGeneric(MacroAssembler* masm); 2044 void GenerateGeneric(MacroAssembler* masm);
2045 2045
2046 bool strict() const { return op() == Token::EQ_STRICT; } 2046 bool strict() const { return op() == Token::EQ_STRICT; }
2047 Condition GetCondition() const; 2047 Condition GetCondition() const;
2048 2048
2049 void AddToSpecialCache(Handle<Code> new_object) override; 2049 // Although we don't cache anything in the special cache we have to define
2050 bool FindCodeInSpecialCache(Code** code_out) override; 2050 // this predicate to avoid appearance of code stubs with embedded maps in
2051 // the global stub cache.
2051 bool UseSpecialCache() override { 2052 bool UseSpecialCache() override {
2052 return state() == CompareICState::KNOWN_RECEIVER; 2053 return state() == CompareICState::KNOWN_RECEIVER;
2053 } 2054 }
2054 2055
2055 class OpBits : public BitField<int, 0, 3> {}; 2056 class OpBits : public BitField<int, 0, 3> {};
2056 class LeftStateBits : public BitField<CompareICState::State, 3, 4> {}; 2057 class LeftStateBits : public BitField<CompareICState::State, 3, 4> {};
2057 class RightStateBits : public BitField<CompareICState::State, 7, 4> {}; 2058 class RightStateBits : public BitField<CompareICState::State, 7, 4> {};
2058 class StateBits : public BitField<CompareICState::State, 11, 4> {}; 2059 class StateBits : public BitField<CompareICState::State, 11, 4> {};
2059 2060
2060 Handle<Map> known_map_; 2061 Handle<Map> known_map_;
(...skipping 1230 matching lines...) Expand 10 before | Expand all | Expand 10 after
3291 #undef DEFINE_HYDROGEN_CODE_STUB 3292 #undef DEFINE_HYDROGEN_CODE_STUB
3292 #undef DEFINE_CODE_STUB 3293 #undef DEFINE_CODE_STUB
3293 #undef DEFINE_CODE_STUB_BASE 3294 #undef DEFINE_CODE_STUB_BASE
3294 3295
3295 extern Representation RepresentationFromType(Type* type); 3296 extern Representation RepresentationFromType(Type* type);
3296 3297
3297 } // namespace internal 3298 } // namespace internal
3298 } // namespace v8 3299 } // namespace v8
3299 3300
3300 #endif // V8_CODE_STUBS_H_ 3301 #endif // V8_CODE_STUBS_H_
OLDNEW
« no previous file with comments | « no previous file | src/code-stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698