Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2053583002:
[ic] Don't pollute per-map code cache with CompareIC stubs. (Closed)
|
Created:
4 years, 6 months ago by Igor Sheludko Modified:
4 years, 6 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[ic] Don't pollute per-map code cache with CompareIC stubs.
Given that
1) because of code flags mismatch we are not able to fetch any CompareIC stub that was put into the cache (we put MONOMORPHIC stubs but query only UNINITIALIZED ones),
2) it was already broken for a couple of years,
3) we will not need to cache any stub once CompareIC becomes vector-based.
Committed: https://crrev.com/172ddf4250e5c4b7510ce352631fb9f8eb291940
Cr-Commit-Position: refs/heads/master@{#36854}
Patch Set 1 : #
Messages
Total messages: 23 (12 generated)
Description was changed from ========== [ic] Don't pollute per-map code cache with CompareIC stubs. Given that 1) because of code flags mismatch we are not able to fetch any CompareIC stub that was put into the cache, 2) it was already broken for a couple of years, 3) we will not need to cache any stub once CompareIC become vector-based. ========== to ========== [ic] Don't pollute per-map code cache with CompareIC stubs. Given that 1) because of code flags mismatch we are not able to fetch any CompareIC stub that was put into the cache (we put MONOMORPHIC stubs but query only UNINITIALIZED ones), 2) it was already broken for a couple of years, 3) we will not need to cache any stub once CompareIC become vector-based. ==========
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053583002/1
Description was changed from ========== [ic] Don't pollute per-map code cache with CompareIC stubs. Given that 1) because of code flags mismatch we are not able to fetch any CompareIC stub that was put into the cache (we put MONOMORPHIC stubs but query only UNINITIALIZED ones), 2) it was already broken for a couple of years, 3) we will not need to cache any stub once CompareIC become vector-based. ========== to ========== [ic] Don't pollute per-map code cache with CompareIC stubs. Given that 1) because of code flags mismatch we are not able to fetch any CompareIC stub that was put into the cache (we put MONOMORPHIC stubs but query only UNINITIALIZED ones), 2) it was already broken for a couple of years, 3) we will not need to cache any stub once CompareIC becomes vector-based. ==========
ishell@chromium.org changed reviewers: + verwaest@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...) v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/6964) v8_mac_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/2888)
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053583002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
jkummerow@chromium.org changed reviewers: + jkummerow@chromium.org
LGTM. I'd like to do more cleanup in that area, but that can wait.
The CQ bit was checked by ishell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053583002/20001
Message was sent while issue was closed.
Description was changed from ========== [ic] Don't pollute per-map code cache with CompareIC stubs. Given that 1) because of code flags mismatch we are not able to fetch any CompareIC stub that was put into the cache (we put MONOMORPHIC stubs but query only UNINITIALIZED ones), 2) it was already broken for a couple of years, 3) we will not need to cache any stub once CompareIC becomes vector-based. ========== to ========== [ic] Don't pollute per-map code cache with CompareIC stubs. Given that 1) because of code flags mismatch we are not able to fetch any CompareIC stub that was put into the cache (we put MONOMORPHIC stubs but query only UNINITIALIZED ones), 2) it was already broken for a couple of years, 3) we will not need to cache any stub once CompareIC becomes vector-based. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [ic] Don't pollute per-map code cache with CompareIC stubs. Given that 1) because of code flags mismatch we are not able to fetch any CompareIC stub that was put into the cache (we put MONOMORPHIC stubs but query only UNINITIALIZED ones), 2) it was already broken for a couple of years, 3) we will not need to cache any stub once CompareIC becomes vector-based. ========== to ========== [ic] Don't pollute per-map code cache with CompareIC stubs. Given that 1) because of code flags mismatch we are not able to fetch any CompareIC stub that was put into the cache (we put MONOMORPHIC stubs but query only UNINITIALIZED ones), 2) it was already broken for a couple of years, 3) we will not need to cache any stub once CompareIC becomes vector-based. Committed: https://crrev.com/172ddf4250e5c4b7510ce352631fb9f8eb291940 Cr-Commit-Position: refs/heads/master@{#36854} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/172ddf4250e5c4b7510ce352631fb9f8eb291940 Cr-Commit-Position: refs/heads/master@{#36854}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in https://codereview.chromium.org/2055793002/ by machenbach@chromium.org. The reason for reverting is: [Sheriff] Speculative revert. Tail call test timing out: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/10014.
Message was sent while issue was closed.
On 2016/06/09 12:24:19, Michael Achenbach wrote: > A revert of this CL (patchset #1 id:20001) has been created in > https://codereview.chromium.org/2055793002/ by mailto:machenbach@chromium.org. > > The reason for reverting is: [Sheriff] Speculative revert. Tail call test timing > out: > https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/10014. Relanded: https://codereview.chromium.org/2051823002/ |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
