Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2053573004: [runtime] Deprecate RUNTIME_ASSERT from debugger methods. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 5 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Deprecate RUNTIME_ASSERT from debugger methods. This removes explicit uses of the RUNTIME_ASSERT macro from some runtime methods. The implicit ones in CONVERT_FOO_ARG_CHECKED will be addressed in a separate CL for all runtime modules at once. R=yangguo@chromium.org BUG=v8:5066 Committed: https://crrev.com/c4781e344c6960203e9d64eecb41d44ad08adfb4 Cr-Commit-Position: refs/heads/master@{#37545}

Patch Set 1 #

Patch Set 2 : Fix failures. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -71 lines) Patch
M src/runtime/runtime-debug.cc View 1 2 32 chunks +48 lines, -41 lines 0 comments Download
M src/runtime/runtime-liveedit.cc View 1 2 11 chunks +19 lines, -20 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-390925.js View 1 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Michael Starzinger
4 years, 5 months ago (2016-07-06 08:49:42 UTC) #3
Yang
On 2016/07/06 08:49:42, Michael Starzinger wrote: LGTM!
4 years, 5 months ago (2016-07-06 08:55:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2053573004/40001
4 years, 5 months ago (2016-07-06 09:04:19 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-06 09:06:21 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 09:06:22 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 09:07:12 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c4781e344c6960203e9d64eecb41d44ad08adfb4
Cr-Commit-Position: refs/heads/master@{#37545}

Powered by Google App Engine
This is Rietveld 408576698