core/fxcodec/codec/ccodec_tiffmodule.h - Issue 2053573003: Clean up fx_codec_tiff.cpp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fxcodec/codec/ccodec_tiffmodule.h

Issue 2053573003: Clean up fx_codec_tiff.cpp. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: remove dead code, stop passing by non-const ref Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fxcodec/codec/ccodec_tiffmodule.h

diff --git a/core/fxcodec/codec/ccodec_tiffmodule.h b/core/fxcodec/codec/ccodec_tiffmodule.h

index d746bb7e85c773f756b88b500adf34139a21bf49..cae9aeb08483c8f568dfbb9867d751b0ce7b0552 100644

--- a/core/fxcodec/codec/ccodec_tiffmodule.h

+++ b/core/fxcodec/codec/ccodec_tiffmodule.h

@@ -20,13 +20,12 @@ class CCodec_TiffModule {

CCodec_TiffContext* CreateDecoder(IFX_FileRead* file_ptr);

- void GetFrames(CCodec_TiffContext* ctx, int32_t& frames);

FX_BOOL LoadFrameInfo(CCodec_TiffContext* ctx,

int32_t frame,

- uint32_t& width,

- uint32_t& height,

- uint32_t& comps,

- uint32_t& bpc,

+ int32_t* width,

+ int32_t* height,

+ int32_t* comps,

+ int32_t* bpc,

CFX_DIBAttribute* pAttribute);

FX_BOOL Decode(CCodec_TiffContext* ctx, class CFX_DIBitmap* pDIBitmap);

void DestroyDecoder(CCodec_TiffContext* ctx);