MD History: Deselect items when clicking 'More from this site'

MD History: Deselect items when clicking 'More from this site'

Previously, it was possible to select an item and perform a domain
search. This would still show '1 selected' in the toolbar, even though
none of the new search results were selected.

BUG=618244
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/18b60480e246ba70731c85f1ad4d55b1cd71911e
Cr-Commit-Position: refs/heads/master@{#399133}

[tsergeant, 2016-06-09 03:42:56]

Description was changed from

==========
MD History: Deselect items when clicking 'More from this site'

Previously, it was possible to select an item and perform a domain
search. This would still show '1 selected' in the toolbar, even though
none of the new search results were selected.

BUG=618244
==========

to

==========
MD History: Deselect items when clicking 'More from this site'

Previously, it was possible to select an item and perform a domain
search. This would still show '1 selected' in the toolbar, even though
none of the new search results were selected.

BUG=618244
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-06-09 03:43:44]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[calamity, 2016-06-09 04:46:18]

Should we just deselect everything on historyResult?

https://codereview.chromium.org/2053553002/diff/1/chrome/test/data/webui/md_h...
File chrome/test/data/webui/md_history/history_list_test.js (right):

https://codereview.chromium.org/2053553002/diff/1/chrome/test/data/webui/md_h...
chrome/test/data/webui/md_history/history_list_test.js:192: assertEquals(0,
toolbar.count);
Mildly surprised this doesn't require another flush.

[tsergeant, 2016-06-09 05:20:31]

Hmm, good point, we can deselect when the search changes and we reset all the
results. Done.

(Ideally, I'd still like this to happen automatically through databinding magic)

https://codereview.chromium.org/2053553002/diff/1/chrome/test/data/webui/md_h...
File chrome/test/data/webui/md_history/history_list_test.js (right):

https://codereview.chromium.org/2053553002/diff/1/chrome/test/data/webui/md_h...
chrome/test/data/webui/md_history/history_list_test.js:192: assertEquals(0,
toolbar.count);
On 2016/06/09 04:46:18, calamity wrote:
> Mildly surprised this doesn't require another flush.

Me too, but nothing asynchronous actually happens.

[calamity, 2016-06-10 05:59:10]

lgtm

[tsergeant, 2016-06-10 06:15:28]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2016-06-10 06:15:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2053553002/20001

[commit-bot: I haz the power, 2016-06-10 07:38:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-10 07:38:26]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-10 07:39:33]

Description was changed from

==========
MD History: Deselect items when clicking 'More from this site'

Previously, it was possible to select an item and perform a domain
search. This would still show '1 selected' in the toolbar, even though
none of the new search results were selected.

BUG=618244
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Deselect items when clicking 'More from this site'

Previously, it was possible to select an item and perform a domain
search. This would still show '1 selected' in the toolbar, even though
none of the new search results were selected.

BUG=618244
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/18b60480e246ba70731c85f1ad4d55b1cd71911e
Cr-Commit-Position: refs/heads/master@{#399133}
==========

[commit-bot: I haz the power, 2016-06-10 07:39:34]

Patchset 2 (id:??) landed as
https://crrev.com/18b60480e246ba70731c85f1ad4d55b1cd71911e
Cr-Commit-Position: refs/heads/master@{#399133}