Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 2053553002: MD History: Deselect items when clicking 'More from this site' (Closed)

Created:
4 years, 6 months ago by tsergeant
Modified:
4 years, 6 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Deselect items when clicking 'More from this site' Previously, it was possible to select an item and perform a domain search. This would still show '1 selected' in the toolbar, even though none of the new search results were selected. BUG=618244 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/18b60480e246ba70731c85f1ad4d55b1cd71911e Cr-Commit-Position: refs/heads/master@{#399133}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Deselect when results come in #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -16 lines) Patch
M chrome/browser/resources/md_history/history_list.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/webui/md_history/history_list_test.js View 1 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_history/history_toolbar_test.js View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
tsergeant
4 years, 6 months ago (2016-06-09 03:43:45 UTC) #3
calamity
Should we just deselect everything on historyResult? https://codereview.chromium.org/2053553002/diff/1/chrome/test/data/webui/md_history/history_list_test.js File chrome/test/data/webui/md_history/history_list_test.js (right): https://codereview.chromium.org/2053553002/diff/1/chrome/test/data/webui/md_history/history_list_test.js#newcode192 chrome/test/data/webui/md_history/history_list_test.js:192: assertEquals(0, toolbar.count); ...
4 years, 6 months ago (2016-06-09 04:46:18 UTC) #4
tsergeant
Hmm, good point, we can deselect when the search changes and we reset all the ...
4 years, 6 months ago (2016-06-09 05:20:31 UTC) #5
calamity
lgtm
4 years, 6 months ago (2016-06-10 05:59:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053553002/20001
4 years, 6 months ago (2016-06-10 06:15:40 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-10 07:38:22 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 07:38:26 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 07:39:34 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/18b60480e246ba70731c85f1ad4d55b1cd71911e
Cr-Commit-Position: refs/heads/master@{#399133}

Powered by Google App Engine
This is Rietveld 408576698