Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: src/log.cc

Issue 2053523003: Refactor CpuProfiler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index 040109535b247f2cf660b7f3e5646fef23afed89..2089917fc80abc1f3fda6cec61d1259cc15a23b7 100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -22,6 +22,7 @@
#include "src/macro-assembler.h"
#include "src/perf-jit.h"
#include "src/profiler/cpu-profiler-inl.h"
+#include "src/profiler/profiler-listener.h"
#include "src/runtime-profiler.h"
#include "src/string-stream.h"
#include "src/vm-state-inl.h"
@@ -754,6 +755,7 @@ Logger::Logger(Isolate* isolate)
perf_jit_logger_(NULL),
ll_logger_(NULL),
jit_logger_(NULL),
+ profiler_listener_(NULL),
listeners_(5),
is_initialized_(false) {}
@@ -1816,6 +1818,11 @@ void Logger::SetCodeEventHandler(uint32_t options,
}
}
+void Logger::SetUpProfilerListener() {
+ if (profiler_listener_ || !is_initialized_) return;
+ profiler_listener_ = new ProfilerListener(isolate_);
+ addCodeEventListener(profiler_listener_);
+}
sampler::Sampler* Logger::sampler() {
return ticker_;
@@ -1860,6 +1867,12 @@ FILE* Logger::TearDown() {
jit_logger_ = NULL;
}
+ if (profiler_listener_) {
+ removeCodeEventListener(profiler_listener_);
+ delete profiler_listener_;
+ profiler_listener_ = NULL;
+ }
+
return log_->Close();
}
« no previous file with comments | « src/log.h ('k') | src/profiler/cpu-profiler.h » ('j') | src/profiler/cpu-profiler.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698