Issue 2053523003: Refactor CpuProfiler.

lpy

lpy@chromium.org changed reviewers: + alph@chromium.org, jochen@chromium.org, yangguo@chromium.org

4 years, 6 months ago (2016-06-09 17:56:06 UTC) #1

alph

https://codereview.chromium.org/2053523003/diff/20001/src/profiler/cpu-profiler.cc File src/profiler/cpu-profiler.cc (right): https://codereview.chromium.org/2053523003/diff/20001/src/profiler/cpu-profiler.cc#newcode28 src/profiler/cpu-profiler.cc:28: static void DispatchCodeEvents(const CodeEventsContainer& evt_rec) { Hmm, not sure ...

4 years, 6 months ago (2016-06-10 22:00:24 UTC) #3

lpy

Description was changed from ========== Refactor CpuProfiler. Currently CpuProfiler is a subclass of CodeEventListener, it ...

4 years, 6 months ago (2016-06-13 10:05:28 UTC) #4

Description was changed from

==========
Refactor CpuProfiler.

Currently CpuProfiler is a subclass of CodeEventListener, it listens code events
from Logger, constructs and stores CodeEventsContainer. This patch is part of
the effort to split the logic of CodeEventListener as ProfilerListener out of
the profiling functionality logic in CpuProfiler. A ProfilerListener will listen
to code events, construct code event to CodeEventsContainer and pass it to code
event handler.

The reason we refactor CpuProfiler is that eventually we want to move
CpuProfiler as part of sampler library and code event listener should stay
inside V8.

Main changes:
1. Refactored CpuProfiler into two parts, the CpuProfiler with profling
functionality and the ProfilerListener listening to code events from Logger.
2. Created CpuProfilerManager to manage a list of CpuProfiler with a static
method dispatching well constructed code events from ProfilerListener to every
registered CpuProfiler.
3. Moved code entry list from CodeEntry to ProfilerListener.

Minor changes:
1. Moved static code entry as part of CodeEntry.
2. Added ProfilerListener to Logger.

BUG=v8:4789
==========

to

==========
Refactor CpuProfiler.

Currently CpuProfiler is a subclass of CodeEventListener, it listens code events
from Logger, constructs and stores CodeEventsContainer. This patch is part of
the effort to split the logic of CodeEventListener as ProfilerListener out of
the profiling functionality logic in CpuProfiler. A ProfilerListener will listen
to code events, construct code event to CodeEventsContainer and pass it to code
event handler.

The reason we refactor CpuProfiler is that eventually we want to move
CpuProfiler as part of sampler library and code event listener should stay
inside V8.

Main changes:
1. Refactored CpuProfiler into two parts, the CpuProfiler with profling
functionality and the ProfilerListener listening to code events from Logger.
2. Created CodeEventObserver and made CpuProfiler inherit from it.
ProfilerListener will have a list of observers and call CodeEventHandler once a
code event is created.
3. Moved code entry list from CodeEntry to ProfilerListener.

Minor changes:
1. Moved static code entry as part of CodeEntry.
2. Added ProfilerListener to Logger.

BUG=v8:4789
==========

lpy

On 2016/06/10 22:00:24, alph wrote: > https://codereview.chromium.org/2053523003/diff/20001/src/profiler/cpu-profiler.cc > File src/profiler/cpu-profiler.cc (right): > > https://codereview.chromium.org/2053523003/diff/20001/src/profiler/cpu-profiler.cc#newcode28 > ...

4 years, 6 months ago (2016-06-13 12:21:49 UTC) #5

alph

https://codereview.chromium.org/2053523003/diff/100001/src/profiler/cpu-profiler.cc File src/profiler/cpu-profiler.cc (right): https://codereview.chromium.org/2053523003/diff/100001/src/profiler/cpu-profiler.cc#newcode293 src/profiler/cpu-profiler.cc:293: RESOLVE_CODE_EVENT(isolate_); Why it needs to be a macro? https://codereview.chromium.org/2053523003/diff/100001/src/profiler/profiler-listener.cc ...

4 years, 6 months ago (2016-06-14 03:48:45 UTC) #6

lpy

I updated the CL. PTAL. https://codereview.chromium.org/2053523003/diff/100001/src/profiler/cpu-profiler.cc File src/profiler/cpu-profiler.cc (right): https://codereview.chromium.org/2053523003/diff/100001/src/profiler/cpu-profiler.cc#newcode293 src/profiler/cpu-profiler.cc:293: RESOLVE_CODE_EVENT(isolate_); On 2016/06/14 03:48:45, ...

4 years, 6 months ago (2016-06-14 09:53:47 UTC) #7

Yang

On 2016/06/15 15:20:25, lpy wrote: > I rebased the CL. > gentle ping. lgtm.

4 years, 6 months ago (2016-06-16 04:38:20 UTC) #9

alph

https://codereview.chromium.org/2053523003/diff/160001/src/profiler/cpu-profiler.cc File src/profiler/cpu-profiler.cc (right): https://codereview.chromium.org/2053523003/diff/160001/src/profiler/cpu-profiler.cc#newcode206 src/profiler/cpu-profiler.cc:206: case CodeEventRecord::CODE_DISABLE_OPT: { nit: drop {} https://codereview.chromium.org/2053523003/diff/160001/src/profiler/cpu-profiler.cc#newcode212 src/profiler/cpu-profiler.cc:212: CodeDeoptEventRecord* ...

4 years, 6 months ago (2016-06-16 09:31:22 UTC) #10

lpy

Thanks for the comments. PTAL. https://codereview.chromium.org/2053523003/diff/160001/src/profiler/cpu-profiler.cc File src/profiler/cpu-profiler.cc (right): https://codereview.chromium.org/2053523003/diff/160001/src/profiler/cpu-profiler.cc#newcode206 src/profiler/cpu-profiler.cc:206: case CodeEventRecord::CODE_DISABLE_OPT: { On ...

4 years, 6 months ago (2016-06-16 12:40:52 UTC) #11

alph

https://codereview.chromium.org/2053523003/diff/180001/src/profiler/cpu-profiler.cc File src/profiler/cpu-profiler.cc (right): https://codereview.chromium.org/2053523003/diff/180001/src/profiler/cpu-profiler.cc#newcode291 src/profiler/cpu-profiler.cc:291: profiler_listener->StartBuildingCodeEntry(); EnableBuildingCodeEntries ? https://codereview.chromium.org/2053523003/diff/180001/src/profiler/profile-generator.h File src/profiler/profile-generator.h (right): https://codereview.chromium.org/2053523003/diff/180001/src/profiler/profile-generator.h#newcode124 src/profiler/profile-generator.h:124: ...

4 years, 6 months ago (2016-06-17 10:38:45 UTC) #12

lpy

Thanks, I addressed comments. https://codereview.chromium.org/2053523003/diff/180001/src/profiler/cpu-profiler.cc File src/profiler/cpu-profiler.cc (right): https://codereview.chromium.org/2053523003/diff/180001/src/profiler/cpu-profiler.cc#newcode291 src/profiler/cpu-profiler.cc:291: profiler_listener->StartBuildingCodeEntry(); On 2016/06/17 10:38:44, alph_slow ...

4 years, 6 months ago (2016-06-17 13:55:00 UTC) #13

alph

https://codereview.chromium.org/2053523003/diff/200001/src/profiler/cpu-profiler.cc File src/profiler/cpu-profiler.cc (right): https://codereview.chromium.org/2053523003/diff/200001/src/profiler/cpu-profiler.cc#newcode290 src/profiler/cpu-profiler.cc:290: logger->SetUpProfilerListener(); So basically now once profiler is started if ...

4 years, 6 months ago (2016-06-17 14:25:18 UTC) #14

lpy

PTAL. I updated the CL. Now profiler listener will be removed from code event dispatcher ...

4 years, 6 months ago (2016-06-17 23:09:02 UTC) #15

alph

Thank you. lgtm % nits https://codereview.chromium.org/2053523003/diff/220001/src/log.cc File src/log.cc (right): https://codereview.chromium.org/2053523003/diff/220001/src/log.cc#newcode763 src/log.cc:763: profiler_listener_.reset(); nit: don't need ...

4 years, 6 months ago (2016-06-19 03:05:41 UTC) #16

lpy

Thanks for the review. https://codereview.chromium.org/2053523003/diff/220001/src/log.cc File src/log.cc (right): https://codereview.chromium.org/2053523003/diff/220001/src/log.cc#newcode763 src/log.cc:763: profiler_listener_.reset(); On 2016/06/19 03:05:40, alph_slow ...

4 years, 6 months ago (2016-06-20 17:16:55 UTC) #17

lpy

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org, alph@chromium.org Link to ...

4 years, 6 months ago (2016-06-20 17:23:26 UTC) #19

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053523003/240001

4 years, 6 months ago (2016-06-20 17:23:31 UTC) #20

commit-bot: I haz the power

Description was changed from ========== Refactor CpuProfiler. Currently CpuProfiler is a subclass of CodeEventListener, it ...

4 years, 6 months ago (2016-06-20 17:25:36 UTC) #21

Message was sent while issue was closed.

Description was changed from

==========
Refactor CpuProfiler.

Currently CpuProfiler is a subclass of CodeEventListener, it listens code events
from Logger, constructs and stores CodeEventsContainer. This patch is part of
the effort to split the logic of CodeEventListener as ProfilerListener out of
the profiling functionality logic in CpuProfiler. A ProfilerListener will listen
to code events, construct code event to CodeEventsContainer and pass it to code
event handler.

The reason we refactor CpuProfiler is that eventually we want to move
CpuProfiler as part of sampler library and code event listener should stay
inside V8.

Main changes:
1. Refactored CpuProfiler into two parts, the CpuProfiler with profling
functionality and the ProfilerListener listening to code events from Logger.
2. Created CodeEventObserver and made CpuProfiler inherit from it.
ProfilerListener will have a list of observers and call CodeEventHandler once a
code event is created.
3. Moved code entry list from CodeEntry to ProfilerListener.

Minor changes:
1. Moved static code entry as part of CodeEntry.
2. Added ProfilerListener to Logger.

BUG=v8:4789
==========

to

==========
Refactor CpuProfiler.

Currently CpuProfiler is a subclass of CodeEventListener, it listens code events
from Logger, constructs and stores CodeEventsContainer. This patch is part of
the effort to split the logic of CodeEventListener as ProfilerListener out of
the profiling functionality logic in CpuProfiler. A ProfilerListener will listen
to code events, construct code event to CodeEventsContainer and pass it to code
event handler.

The reason we refactor CpuProfiler is that eventually we want to move
CpuProfiler as part of sampler library and code event listener should stay
inside V8.

Main changes:
1. Refactored CpuProfiler into two parts, the CpuProfiler with profling
functionality and the ProfilerListener listening to code events from Logger.
2. Created CodeEventObserver and made CpuProfiler inherit from it.
ProfilerListener will have a list of observers and call CodeEventHandler once a
code event is created.
3. Moved code entry list from CodeEntry to ProfilerListener.

Minor changes:
1. Moved static code entry as part of CodeEntry.
2. Added ProfilerListener to Logger.

BUG=v8:4789
==========

commit-bot: I haz the power

Description was changed from ========== Refactor CpuProfiler. Currently CpuProfiler is a subclass of CodeEventListener, it ...

4 years, 6 months ago (2016-06-20 17:26:49 UTC) #23

Message was sent while issue was closed.

Description was changed from

==========
Refactor CpuProfiler.

Currently CpuProfiler is a subclass of CodeEventListener, it listens code events
from Logger, constructs and stores CodeEventsContainer. This patch is part of
the effort to split the logic of CodeEventListener as ProfilerListener out of
the profiling functionality logic in CpuProfiler. A ProfilerListener will listen
to code events, construct code event to CodeEventsContainer and pass it to code
event handler.

The reason we refactor CpuProfiler is that eventually we want to move
CpuProfiler as part of sampler library and code event listener should stay
inside V8.

Main changes:
1. Refactored CpuProfiler into two parts, the CpuProfiler with profling
functionality and the ProfilerListener listening to code events from Logger.
2. Created CodeEventObserver and made CpuProfiler inherit from it.
ProfilerListener will have a list of observers and call CodeEventHandler once a
code event is created.
3. Moved code entry list from CodeEntry to ProfilerListener.

Minor changes:
1. Moved static code entry as part of CodeEntry.
2. Added ProfilerListener to Logger.

BUG=v8:4789
==========

to

==========
Refactor CpuProfiler.

Currently CpuProfiler is a subclass of CodeEventListener, it listens code events
from Logger, constructs and stores CodeEventsContainer. This patch is part of
the effort to split the logic of CodeEventListener as ProfilerListener out of
the profiling functionality logic in CpuProfiler. A ProfilerListener will listen
to code events, construct code event to CodeEventsContainer and pass it to code
event handler.

The reason we refactor CpuProfiler is that eventually we want to move
CpuProfiler as part of sampler library and code event listener should stay
inside V8.

Main changes:
1. Refactored CpuProfiler into two parts, the CpuProfiler with profling
functionality and the ProfilerListener listening to code events from Logger.
2. Created CodeEventObserver and made CpuProfiler inherit from it.
ProfilerListener will have a list of observers and call CodeEventHandler once a
code event is created.
3. Moved code entry list from CodeEntry to ProfilerListener.

Minor changes:
1. Moved static code entry as part of CodeEntry.
2. Added ProfilerListener to Logger.

BUG=v8:4789

Committed: https://crrev.com/cb59fc1facc9b390e2c7544b4da56a4e0a9b3222
Cr-Commit-Position: refs/heads/master@{#37112}
==========

commit-bot: I haz the power

Patchset 13 (id:??) landed as https://crrev.com/cb59fc1facc9b390e2c7544b4da56a4e0a9b3222 Cr-Commit-Position: refs/heads/master@{#37112}

4 years, 6 months ago (2016-06-20 17:26:51 UTC) #24

lpy

A revert of this CL (patchset #13 id:240001) has been created in https://codereview.chromium.org/2079273003/ by lpy@chromium.org. ...

4 years, 6 months ago (2016-06-20 17:51:45 UTC) #25

lpy

Description was changed from ========== Refactor CpuProfiler. Currently CpuProfiler is a subclass of CodeEventListener, it ...

4 years, 6 months ago (2016-06-20 17:53:42 UTC) #26

Message was sent while issue was closed.

Description was changed from

==========
Refactor CpuProfiler.

Currently CpuProfiler is a subclass of CodeEventListener, it listens code events
from Logger, constructs and stores CodeEventsContainer. This patch is part of
the effort to split the logic of CodeEventListener as ProfilerListener out of
the profiling functionality logic in CpuProfiler. A ProfilerListener will listen
to code events, construct code event to CodeEventsContainer and pass it to code
event handler.

The reason we refactor CpuProfiler is that eventually we want to move
CpuProfiler as part of sampler library and code event listener should stay
inside V8.

Main changes:
1. Refactored CpuProfiler into two parts, the CpuProfiler with profling
functionality and the ProfilerListener listening to code events from Logger.
2. Created CodeEventObserver and made CpuProfiler inherit from it.
ProfilerListener will have a list of observers and call CodeEventHandler once a
code event is created.
3. Moved code entry list from CodeEntry to ProfilerListener.

Minor changes:
1. Moved static code entry as part of CodeEntry.
2. Added ProfilerListener to Logger.

BUG=v8:4789

Committed: https://crrev.com/cb59fc1facc9b390e2c7544b4da56a4e0a9b3222
Cr-Commit-Position: refs/heads/master@{#37112}
==========

to

==========
Refactor CpuProfiler.

Currently CpuProfiler is a subclass of CodeEventListener, it listens code events
from Logger, constructs and stores CodeEventsContainer. This patch is part of
the effort to split the logic of CodeEventListener as ProfilerListener out of
the profiling functionality logic in CpuProfiler. A ProfilerListener will listen
to code events, construct code event to CodeEventsContainer and pass it to code
event handler.

The reason we refactor CpuProfiler is that eventually we want to move
CpuProfiler as part of sampler library and code event listener should stay
inside V8.

Main changes:
1. Refactored CpuProfiler into two parts, the CpuProfiler with profling
functionality and the ProfilerListener listening to code events from Logger.
2. Created CodeEventObserver and made CpuProfiler inherit from it.
ProfilerListener will have a list of observers and call CodeEventHandler once a
code event is created.
3. Moved code entry list from CodeEntry to ProfilerListener.

Minor changes:
1. Moved static code entry as part of CodeEntry.
2. Added ProfilerListener to Logger.

BUG=v8:4789

Committed: https://crrev.com/cb59fc1facc9b390e2c7544b4da56a4e0a9b3222
Cr-Commit-Position: refs/heads/master@{#37112}
==========

lpy

cc v8-mips-ports@ group This CL couldn't be compiled in V8 ports on V8 Mips builder ...

4 years, 6 months ago (2016-06-20 20:32:20 UTC) #27

lpy

Description was changed from ========== Refactor CpuProfiler. Currently CpuProfiler is a subclass of CodeEventListener, it ...

4 years, 6 months ago (2016-06-22 16:14:33 UTC) #28

Description was changed from

==========
Refactor CpuProfiler.

Currently CpuProfiler is a subclass of CodeEventListener, it listens code events
from Logger, constructs and stores CodeEventsContainer. This patch is part of
the effort to split the logic of CodeEventListener as ProfilerListener out of
the profiling functionality logic in CpuProfiler. A ProfilerListener will listen
to code events, construct code event to CodeEventsContainer and pass it to code
event handler.

The reason we refactor CpuProfiler is that eventually we want to move
CpuProfiler as part of sampler library and code event listener should stay
inside V8.

Main changes:
1. Refactored CpuProfiler into two parts, the CpuProfiler with profling
functionality and the ProfilerListener listening to code events from Logger.
2. Created CodeEventObserver and made CpuProfiler inherit from it.
ProfilerListener will have a list of observers and call CodeEventHandler once a
code event is created.
3. Moved code entry list from CodeEntry to ProfilerListener.

Minor changes:
1. Moved static code entry as part of CodeEntry.
2. Added ProfilerListener to Logger.

BUG=v8:4789

Committed: https://crrev.com/cb59fc1facc9b390e2c7544b4da56a4e0a9b3222
Cr-Commit-Position: refs/heads/master@{#37112}
==========

to

==========
[Reland] Refactor CpuProfiler.

Currently CpuProfiler is a subclass of CodeEventListener, it listens code events
from Logger, constructs and stores CodeEventsContainer. This patch is part of
the effort to split the logic of CodeEventListener as ProfilerListener out of
the profiling functionality logic in CpuProfiler. A ProfilerListener will listen
to code events, construct code event to CodeEventsContainer and pass it to code
event handler.

The reason we refactor CpuProfiler is that eventually we want to move
CpuProfiler as part of sampler library and code event listener should stay
inside V8.

Main changes:
1. Refactored CpuProfiler into two parts, the CpuProfiler with profling
functionality and the ProfilerListener listening to code events from Logger.
2. Created CodeEventObserver and made CpuProfiler inherit from it.
ProfilerListener will have a list of observers and call CodeEventHandler once a
code event is created.
3. Moved code entry list from CodeEntry to ProfilerListener.

Minor changes:
1. Moved static code entry as part of CodeEntry.
2. Added ProfilerListener to Logger.

BUG=v8:4789

Committed: https://crrev.com/cb59fc1facc9b390e2c7544b4da56a4e0a9b3222
Cr-Commit-Position: refs/heads/master@{#37112}
==========

lpy

As we discussed, I will check in the code one more time to see if ...

4 years, 6 months ago (2016-06-22 16:15:47 UTC) #29

lpy

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org, yangguo@chromium.org Link to ...

4 years, 6 months ago (2016-06-22 16:16:00 UTC) #31

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053523003/260001

4 years, 6 months ago (2016-06-22 16:16:04 UTC) #32

commit-bot: I haz the power

Description was changed from ========== [Reland] Refactor CpuProfiler. Currently CpuProfiler is a subclass of CodeEventListener, ...

4 years, 6 months ago (2016-06-22 16:43:56 UTC) #33

Message was sent while issue was closed.

Description was changed from

==========
[Reland] Refactor CpuProfiler.

Currently CpuProfiler is a subclass of CodeEventListener, it listens code events
from Logger, constructs and stores CodeEventsContainer. This patch is part of
the effort to split the logic of CodeEventListener as ProfilerListener out of
the profiling functionality logic in CpuProfiler. A ProfilerListener will listen
to code events, construct code event to CodeEventsContainer and pass it to code
event handler.

The reason we refactor CpuProfiler is that eventually we want to move
CpuProfiler as part of sampler library and code event listener should stay
inside V8.

Main changes:
1. Refactored CpuProfiler into two parts, the CpuProfiler with profling
functionality and the ProfilerListener listening to code events from Logger.
2. Created CodeEventObserver and made CpuProfiler inherit from it.
ProfilerListener will have a list of observers and call CodeEventHandler once a
code event is created.
3. Moved code entry list from CodeEntry to ProfilerListener.

Minor changes:
1. Moved static code entry as part of CodeEntry.
2. Added ProfilerListener to Logger.

BUG=v8:4789

Committed: https://crrev.com/cb59fc1facc9b390e2c7544b4da56a4e0a9b3222
Cr-Commit-Position: refs/heads/master@{#37112}
==========

to

==========
[Reland] Refactor CpuProfiler.

Currently CpuProfiler is a subclass of CodeEventListener, it listens code events
from Logger, constructs and stores CodeEventsContainer. This patch is part of
the effort to split the logic of CodeEventListener as ProfilerListener out of
the profiling functionality logic in CpuProfiler. A ProfilerListener will listen
to code events, construct code event to CodeEventsContainer and pass it to code
event handler.

The reason we refactor CpuProfiler is that eventually we want to move
CpuProfiler as part of sampler library and code event listener should stay
inside V8.

Main changes:
1. Refactored CpuProfiler into two parts, the CpuProfiler with profling
functionality and the ProfilerListener listening to code events from Logger.
2. Created CodeEventObserver and made CpuProfiler inherit from it.
ProfilerListener will have a list of observers and call CodeEventHandler once a
code event is created.
3. Moved code entry list from CodeEntry to ProfilerListener.

Minor changes:
1. Moved static code entry as part of CodeEntry.
2. Added ProfilerListener to Logger.

BUG=v8:4789

Committed: https://crrev.com/cb59fc1facc9b390e2c7544b4da56a4e0a9b3222
Cr-Commit-Position: refs/heads/master@{#37112}
==========

commit-bot: I haz the power

Description was changed from ========== [Reland] Refactor CpuProfiler. Currently CpuProfiler is a subclass of CodeEventListener, ...

4 years, 6 months ago (2016-06-22 16:47:07 UTC) #35

Message was sent while issue was closed.

Description was changed from

==========
[Reland] Refactor CpuProfiler.

Currently CpuProfiler is a subclass of CodeEventListener, it listens code events
from Logger, constructs and stores CodeEventsContainer. This patch is part of
the effort to split the logic of CodeEventListener as ProfilerListener out of
the profiling functionality logic in CpuProfiler. A ProfilerListener will listen
to code events, construct code event to CodeEventsContainer and pass it to code
event handler.

The reason we refactor CpuProfiler is that eventually we want to move
CpuProfiler as part of sampler library and code event listener should stay
inside V8.

Main changes:
1. Refactored CpuProfiler into two parts, the CpuProfiler with profling
functionality and the ProfilerListener listening to code events from Logger.
2. Created CodeEventObserver and made CpuProfiler inherit from it.
ProfilerListener will have a list of observers and call CodeEventHandler once a
code event is created.
3. Moved code entry list from CodeEntry to ProfilerListener.

Minor changes:
1. Moved static code entry as part of CodeEntry.
2. Added ProfilerListener to Logger.

BUG=v8:4789

Committed: https://crrev.com/cb59fc1facc9b390e2c7544b4da56a4e0a9b3222
Cr-Commit-Position: refs/heads/master@{#37112}
==========

to

==========
[Reland] Refactor CpuProfiler.

Currently CpuProfiler is a subclass of CodeEventListener, it listens code events
from Logger, constructs and stores CodeEventsContainer. This patch is part of
the effort to split the logic of CodeEventListener as ProfilerListener out of
the profiling functionality logic in CpuProfiler. A ProfilerListener will listen
to code events, construct code event to CodeEventsContainer and pass it to code
event handler.

The reason we refactor CpuProfiler is that eventually we want to move
CpuProfiler as part of sampler library and code event listener should stay
inside V8.

Main changes:
1. Refactored CpuProfiler into two parts, the CpuProfiler with profling
functionality and the ProfilerListener listening to code events from Logger.
2. Created CodeEventObserver and made CpuProfiler inherit from it.
ProfilerListener will have a list of observers and call CodeEventHandler once a
code event is created.
3. Moved code entry list from CodeEntry to ProfilerListener.

Minor changes:
1. Moved static code entry as part of CodeEntry.
2. Added ProfilerListener to Logger.

BUG=v8:4789

Committed: https://crrev.com/cb59fc1facc9b390e2c7544b4da56a4e0a9b3222
Committed: https://crrev.com/04f710ac20e30ca2d903b0853947b6660ad1e16d
Cr-Original-Commit-Position: refs/heads/master@{#37112}
Cr-Commit-Position: refs/heads/master@{#37195}
==========

commit-bot: I haz the power

4 years, 6 months ago (2016-06-22 16:47:09 UTC) #36

Message was sent while issue was closed.

Patchset 14 (id:??) landed as
https://crrev.com/04f710ac20e30ca2d903b0853947b6660ad1e16d
Cr-Commit-Position: refs/heads/master@{#37195}

Issue 2053523003: Refactor CpuProfiler. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Move CpuProfilerManager to .cc #

Patch Set 3 : rebase #

Patch Set 4 : remove cpuprofilermanager, use code event observer #

Patch Set 5 #

Patch Set 6 #

Patch Set 7 #

Patch Set 8 : rebase #

Patch Set 9 : rebase #

Patch Set 10 : address alph's comments #

Patch Set 11 #

Patch Set 12 : stop profiler listener when there's no cpu profiler #

Patch Set 13 : addressed alph's nits. #

Patch Set 14 : rebase #

Messages