Fix a bug that in progress notification can change when auto resumption starts

Fix a bug that in progress notification can change when auto resumption starts

When a download is in progress, auto resumption should be an
no-op for it.
However, auto resumption changes the notification icon when started.
This CL fixes that issue.

BUG=618480
Committed: https://crrev.com/fced9ce5b94c3385b2be0cbe6e102007a9dea54b
Cr-Commit-Position: refs/heads/master@{#399237}

[qinmin, 2016-06-08 23:27:27]

qinmin@chromium.org changed reviewers:
+ tedchoc@chromium.org

[qinmin, 2016-06-08 23:27:27]

PTAL

[Ted C, 2016-06-09 23:25:20]

lgtm

https://codereview.chromium.org/2053523002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(right):

https://codereview.chromium.org/2053523002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:209:
mDownloadsInProgress.remove(downloadGuid);
this is handled in cancelNotification above

https://codereview.chromium.org/2053523002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:501:
if (mDownloadsInProgress.contains(entry.downloadGuid)) continue;
it is sad to me that we can't rely on some data from the shared pref entry, but
I see that in notifyDownloadPaused, we don't remove the item if it is resumable
so that is the case that cases this to break

[qinmin, 2016-06-09 23:37:22]

https://codereview.chromium.org/2053523002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(right):

https://codereview.chromium.org/2053523002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:209:
mDownloadsInProgress.remove(downloadGuid);
On 2016/06/09 23:25:20, Ted C wrote:
> this is handled in cancelNotification above

Done.removed

https://codereview.chromium.org/2053523002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:501:
if (mDownloadsInProgress.contains(entry.downloadGuid)) continue;
On 2016/06/09 23:25:20, Ted C wrote:
> it is sad to me that we can't rely on some data from the shared pref entry,
but
> I see that in notifyDownloadPaused, we don't remove the item if it is
resumable
> so that is the case that cases this to break

Yes, the sharedPrefs is for downloads that can be auto resumed, but this List is
for downloads that is already resumed.

[qinmin, 2016-06-09 23:37:25]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-06-09 23:37:26]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2053523002/#ps20001
(title: "remove a redundant call")

[commit-bot: I haz the power, 2016-06-09 23:37:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2053523002/20001

[commit-bot: I haz the power, 2016-06-10 01:39:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 01:39:30]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)

[qinmin, 2016-06-10 17:55:49]

Patchset #2 (id:20001) has been deleted

[qinmin, 2016-06-10 17:56:12]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-06-10 17:56:12]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2053523002/#ps40001
(title: "remove redundant call")

[commit-bot: I haz the power, 2016-06-10 17:56:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2053523002/40001

[commit-bot: I haz the power, 2016-06-10 18:42:44]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-06-10 18:42:46]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-10 18:44:01]

Description was changed from

==========
Fix a bug that in progress notification can change when auto resumption starts

When a download is in progress, auto resumption should be an
no-op for it.
However, auto resumption changes the notification icon when started.
This CL fixes that issue.

BUG=618480
==========

to

==========
Fix a bug that in progress notification can change when auto resumption starts

When a download is in progress, auto resumption should be an
no-op for it.
However, auto resumption changes the notification icon when started.
This CL fixes that issue.

BUG=618480

Committed: https://crrev.com/fced9ce5b94c3385b2be0cbe6e102007a9dea54b
Cr-Commit-Position: refs/heads/master@{#399237}
==========

[commit-bot: I haz the power, 2016-06-10 18:44:03]

Patchset 2 (id:??) landed as
https://crrev.com/fced9ce5b94c3385b2be0cbe6e102007a9dea54b
Cr-Commit-Position: refs/heads/master@{#399237}